webkit_unit_tests failing on 4 builders Type: build-failure Builders failed on: - WebKit Linux Trusty (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29 - WebKit Mac10.11 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29 - WebKit Win x64 Builder (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29 - WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29 All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleClipTreePath/1 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleEffectTreePath/0 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleEffectTreePath/1 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleScrollTreePath/0 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleScrollTreePath/1 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleTransformTreePath/0 ( Code Search ) findit Findit (?) suspects CL 0221e75 All/PaintPropertyTreePrinterTest.SimpleTransformTreePath/1 ( Code Search ) findit Findit (?) suspects CL 0221e75 Cl is https://codereview.chromium.org/2638763003 "Move property tree debugging code to platform/graphics/paint/." Seems relevant.
All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 (run #1): [ RUN ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 ../../third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp:107: Failure Value of: clipPathAsString.ascii().data() Expected: matches regular expression "root .* rect.* .* rect.* .* rect.*" Actual: 0x135ef66731b0 pointing to " 0x4df73c3c790 parent=(nil) localTransformSpace=0x4df73cbc100 rect=-1.67772e+07,-1.67772e+07 3.35544e+07x3.35544e+07 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x4df73c3ca90 parent=0x4df73c3c790 localTransformSpace=0x4df73cbc970 rect=0,0 800x600 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x4df73c3cb10 parent=0x4df73c3ca90 localTransformSpace=0x4df73cbc970 rect=48,18 40x60 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none?" [ FAILED ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0, where GetParam() = false (11 ms) All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 (run #2): [ RUN ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 ../../third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp:107: Failure Value of: clipPathAsString.ascii().data() Expected: matches regular expression "root .* rect.* .* rect.* .* rect.*" Actual: 0x13c1b26142b0 pointing to " 0x1bdfe223c790 parent=(nil) localTransformSpace=0x1bdfe22bc100 rect=-1.67772e+07,-1.67772e+07 3.35544e+07x3.35544e+07 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x1bdfe223c810 parent=0x1bdfe223c790 localTransformSpace=0x1bdfe22bc1f0 rect=0,0 800x600 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x1bdfe223c890 parent=0x1bdfe223c810 localTransformSpace=0x1bdfe22bc1f0 rect=48,18 40x60 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none?" [ FAILED ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0, where GetParam() = false (68 ms) All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 (run #3): [ RUN ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 ../../third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp:107: Failure Value of: clipPathAsString.ascii().data() Expected: matches regular expression "root .* rect.* .* rect.* .* rect.*" Actual: 0x2b8bfda142b0 pointing to " 0x1deff063c790 parent=(nil) localTransformSpace=0x1deff06bc100 rect=-1.67772e+07,-1.67772e+07 3.35544e+07x3.35544e+07 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x1deff063c810 parent=0x1deff063c790 localTransformSpace=0x1deff06bc1f0 rect=0,0 800x600 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x1deff063c890 parent=0x1deff063c810 localTransformSpace=0x1deff06bc1f0 rect=48,18 40x60 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none?" [ FAILED ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0, where GetParam() = false (80 ms) All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 (run #4): [ RUN ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0 ../../third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp:107: Failure Value of: clipPathAsString.ascii().data() Expected: matches regular expression "root .* rect.* .* rect.* .* rect.*" Actual: 0x16d0fd6142b0 pointing to " 0x16a3aca3c790 parent=(nil) localTransformSpace=0x16a3acabc100 rect=-1.67772e+07,-1.67772e+07 3.35544e+07x3.35544e+07 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x16a3aca3c810 parent=0x16a3aca3c790 localTransformSpace=0x16a3acabc1f0 rect=0,0 800x600 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none? 0x16a3aca3c890 parent=0x16a3aca3c810 localTransformSpace=0x16a3acabc1f0 rect=48,18 40x60 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none?" [ FAILED ] All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0, where GetParam() = false (72 ms)
Revert up at https://codereview.chromium.org/2639143002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105f592cb030b5e0b210e15a74a3341ea24e4e75 commit 105f592cb030b5e0b210e15a74a3341ea24e4e75 Author: meade <meade@chromium.org> Date: Wed Jan 18 06:05:11 2017 Revert of Move property tree debugging code to platform/graphics/paint/. (patchset #8 id:140001 of https://codereview.chromium.org/2638763003/ ) Reason for revert: Caused failures on 4 waterfall bots: WebKit Linux Trusty (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/550 WebKit Mac10.11 (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6955 WebKit Win x64 Builder (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/102661 WebKit Win7 (dbg) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8753 BUG= 682113 Original issue's description: > Move property tree debugging code to platform/graphics/paint/. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2638763003 > Cr-Commit-Position: refs/heads/master@{#444190} > Committed: https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adce946ce06d3c0 TBR=wkorman@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2639143002 Cr-Commit-Position: refs/heads/master@{#444293} [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp [modify] https://crrev.com/105f592cb030b5e0b210e15a74a3341ea24e4e75/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
I'm really not sure how the original patch landed.
Removing from sheriff queue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b commit cd60843ee27fdeeb53a6a9f236cf9de4eec5135b Author: chrishtr <chrishtr@chromium.org> Date: Fri Jan 20 22:56:11 2017 Move property tree debugging code to platform/graphics/paint/ (try #2) This is a revert of https://codereview.chromium.org/2639143002, with the following fixes: 1. Add a line in PropertyTreeStatePrinter::pathAsString to output "root" 2. Change #ifndef NDEBUG to #if DCHECK_IS_ON() The former fixes the unittest. The latter ensures the test actually runs on the bots, and increases debugging convenience. BUG= 682113 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2647063002 Cr-Commit-Position: refs/heads/master@{#445197} [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp [modify] https://crrev.com/cd60843ee27fdeeb53a6a9f236cf9de4eec5135b/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
Comment 1 by meade@chromium.org
, Jan 18 2017