New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682112 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Black screenshot appears for Report an Issue Window on freshly launching chrome browser.

Reported by lpa...@etouch.net, Jan 18 2017

Issue description

Chrome Version: 57.0.2984.0 (Official Build)a2377c097a1fa051f90f9c02d96d010073fcb701-refs/heads/master@{#443964} (64-bit)

OS: Windows(8,8.1,10)

Steps to reproduce:
1. Freshly install and launch Chrome, go to wrench icon, select About Google Chrome in Help.
2. Click on Report an Issue, Black screenshot appears in Report Window, Exit Chrome and Launch it again.
3. Go to About google chrome, click on Report an Issue and observe.

Actual Result: Black Screenshot is appearing.
Expected Result: Actual Screenshot should appear.

This is regression issue broken in 'M 57' and will soon update the bisect info:


Manual Bisect Info.
Good Build:  57.0.2980.0
Bad Build:   57.0.2981.0 

Note: 1. Not observed on MAC and LINUX OS.
      2. This issue only appears when freshly installing and launching chrome and exiting chrome and launching it again.

 
Actual Result.mp4
1.6 MB View Download
Expected Result.mp4
1.4 MB View Download

Comment 1 by lpa...@etouch.net, Jan 18 2017

Description: Show this description
Labels: hasbisect-per-revision
Owner: nednguyen@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build : 57.0.2980.0,  Revision Range -443474
Bad build  : 57.0.2981.0,  Revision Range -443771

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/6b8312a4903fc6965a64a3835524f1a8f384f26b..21f869f2b2b57484248fec09e3ce56f5352dd08a

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/21f869f2b2b57484248fec09e3ce56f5352dd08a

From the above CL suspecting the below change
---------------------------
Review-Url:  https://codereview.chromium.org/2629413002

nednguyen@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Thanks..
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Owner: ----
My change is a change to Telemetry benchmark. It has nothing to do with Chrome.
Labels: Needs-Bisect
Cc: sureshkumari@chromium.org
Labels: -Needs-Bisect
Owner: qiangchen@chromium.org
After rebisect this issue find the Bisect info below

Manual Bisect Info:
===================
Good build : 57.0.2965.0,  Revision Range -440816
Bad build  : 57.0.2966.0,  Revision Range -440913

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/e6c54408561d0475510859463da839907d733541..cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6

From the above CL suspecting the below change
---------------------------
Review-Url: https://codereview.chromium.org/2606783002

qiangchen@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Thanks..
Labels: Needs-triage-Mobile
Tried to reproduce the issue on Android 5.0.2 Nexus 7 Build/LRX22G chrome version 57.0.2984.0 by navigating to Menu --> Help & feedback-->Send Feedback

Observed the UI different than Desktop and the scenario can not be reproduce here.

Note: Could not see the option to send feedback on Android 6.0.1 SM-J700F Build/MMB29k by navigating to Menu --> Help & feedback
Cc: zijiehe@chromium.org
zijiehe@: It looks like that DirectX Capturer would return a black frame for the above use case. Do you have any idea?
Cc: sergeyu@chromium.org
Labels: -Needs-triage-Mobile
cc sergeyu@ for further investigation.
The feedback code takes the screenshot by copying canvas as soon as <video> triggers canplay event, see  chrome/browser/resources/feedback/js/take_screenshot.js . It appears that somehow the first frame is black.
I can also repro this issue without restarting chrome after screen resolution is increased, which suggests it's related to  bug 684162 .
Blocking: 663073
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a635db552dea8279eb7655e876555fad7e3aea2

commit 7a635db552dea8279eb7655e876555fad7e3aea2
Author: qiangchen <qiangchen@chromium.org>
Date: Wed Jan 25 18:51:05 2017

Revert of Make DirectX Capturer Default On (patchset #1 id:1 of https://codereview.chromium.org/2606783002/ )

Reason for revert:
Several bugs are found with DirectX Capturer.

Original issue's description:
> Make DirectX Capturer Default On
>
> After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled.
>
> BUG= 314516 
>
> Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6
> Cr-Commit-Position: refs/heads/master@{#440856}

TBR=sergeyu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 314516 , 682112 

Review-Url: https://codereview.chromium.org/2653953004
Cr-Commit-Position: refs/heads/master@{#446068}

[modify] https://crrev.com/7a635db552dea8279eb7655e876555fad7e3aea2/content/browser/media/capture/desktop_capture_device.cc

Blocking: -663073
Labels: Merge-Request-57
Status: Fixed (was: Assigned)
Project Member

Comment 15 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M57 branch 2987, could you please confirm revert lsited at #13 is baked/verified in Canary and safe to merge to M57?
Yes, the GDI capturer was there for long time and works fine. We recently decided to launch the new DirectX capturer for performance improvement, but after we flip the flag on, several bugs including this one were discovered. Thus we decide to defer the launch of DirectX capturer.

The revert is just one line change to flip the flag off.
Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #17. Please merge ASAP. 
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ddc7546352219e321f21d9f0c1249e6725f20b

commit c9ddc7546352219e321f21d9f0c1249e6725f20b
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Jan 26 21:01:00 2017

Revert of Make DirectX Capturer Default On (patchset #1 id:1 of https://codereview.chromium.org/2606783002/ )

Reason for revert:
Several bugs are found with DirectX Capturer.

Original issue's description:
> Make DirectX Capturer Default On
>
> After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled.
>
> BUG= 314516 
>
> Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6
> Cr-Commit-Position: refs/heads/master@{#440856}

TBR=sergeyu@chromium.org
BUG= 314516 , 682112 

Review-Url: https://codereview.chromium.org/2653953004
Cr-Commit-Position: refs/heads/master@{#446068}
(cherry picked from commit 7a635db552dea8279eb7655e876555fad7e3aea2)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2656693005
Cr-Commit-Position: refs/branch-heads/2987@{#119}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/c9ddc7546352219e321f21d9f0c1249e6725f20b/content/browser/media/capture/desktop_capture_device.cc

Cc: qiangchen@chromium.org
Owner: zijiehe@chromium.org
Status: Assigned (was: Fixed)
zijiehe@: Can you take a look at this bug? I think it is related with DirectX Capturer. My above fix is just reverting the launch CL.
Cc: niklase@chromium.org
Yes, we have received three bugs regarding to DX capturer. I am working on them.
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Labels: -ReleaseBlock-Stable
lpa*@etouch.net, would you mind to share us your hardware, brand of video adapter, and driver version, etc?
I have found this kind of issue happens on a virtual machine, which indicates these APIs are not working well on all kinds of hardware.
Labels: -M-57 M-58
m58, since the capturer was disabled in m57
Zijie, FYI I was able to reproduce this problem on HP Z240 with NVidia Quadro K1200
Project Member

Comment 28 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6aa7632954e8cf05354b270a63973e3483e1afb

commit d6aa7632954e8cf05354b270a63973e3483e1afb
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Feb 23 18:58:29 2017

Reland of Make DirectX Capturer Default On (patchset #1 id:1 of https://codereview.chromium.org/2653953004/ )

Reason for revert:
Bring the flag on by default for testing purpose.

Original issue's description:
> Revert of Make DirectX Capturer Default On (patchset #1 id:1 of https://codereview.chromium.org/2606783002/ )
>
> Reason for revert:
> Several bugs are found with DirectX Capturer.
>
> Original issue's description:
> > Make DirectX Capturer Default On
> >
> > After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled.
> >
> > BUG= 314516 
> >
> > Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6
> > Cr-Commit-Position: refs/heads/master@{#440856}
>
> TBR=sergeyu@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 314516 , 682112 
>
> Review-Url: https://codereview.chromium.org/2653953004
> Cr-Commit-Position: refs/heads/master@{#446068}
> Committed: https://chromium.googlesource.com/chromium/src/+/7a635db552dea8279eb7655e876555fad7e3aea2

TBR=sergeyu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 314516 , 682112 

Review-Url: https://codereview.chromium.org/2716663002
Cr-Commit-Position: refs/heads/master@{#452569}

[modify] https://crrev.com/d6aa7632954e8cf05354b270a63973e3483e1afb/content/browser/media/capture/desktop_capture_device.cc

Able to reproduce this issue on Windows 10 with chrome version #58.0.3026.0

Attaching the screen-shot for reference.

zijiehe@ could you please look into it.
Issue 682112.PNG
169 KB View Download
Are you using a virtual machine?
I see a similar issue, which can be addressed by change https://codereview.chromium.org/2709523003/. It should be submitted soon or later.
zijiehe@ My Windows 10 is a physical(laptop - lenovo thinkpad) machine.
  
Would you please provide more information? i.e. Windows version (Is it 1607?), model, video adapter.
The issue Kiran reported is a different one, change https://codereview.chromium.org/2709523003/ should resolve it.
The original issue should be resolved by change https://codereview.chromium.org/2703123002/.
Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
Labels: Merge-Request-58
Status: Started (was: Fixed)
Neet to merge https://codereview.chromium.org/2697453002/ to M58
s/Neet/Need/
Project Member

Comment 37 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Merge-Review-58
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M58, could you please confirm change listed at #35 is well baked/verified in Canary, having enough automation coverage and will be a safe merge? Thank you.
Cc: abdulsyed@chromium.org
Kiran, would you mind to confirm the positive impact of this change?
I've verified that the issue is fixed in canary.

Comment 42 Deleted

Approving merge to M58 branch 3029 based on comment #41. Please merge before 5:00 PM PT, Monday on so we can take it in for next week dev release. Thank you.
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

Project Member

Comment 45 by bugdroid1@chromium.org, Mar 13 2017

Labels: merge-merged-58
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5

commit c622c51234ae7fb0a0c6c45c74a8a8ee073482d5
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Mar 13 18:50:13 2017

BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame

DXGI capturer highly depends on video adapter and its driver, as well as Windows
itself. I recently found it cannot work on my virtualbox instance any more,
which indicates it may not work well on some specific systems. What worse is,
the APIs do not return a failure in such case.

So this change adds a BlankDetectorDesktopCapturerWrapper, which samples several
pixels in the frame returned by a DesktopCapturer implementation. If all the
pixels selected are blank, this wrapper returns a failure. A typical usage is to
combine BlankDetectorDesktopCapturerWrapper with FallbackDesktopCapturerWrapper,
and use GDI capturer in case of failure.

Usually less than 10000 pixels are checked, so the
BlankDetectorDesktopCapturerWrapper should not significant impact the capturer
performance.

This change is expected to resolve  bug 682112  in another dimension.

BUG= chromium:682112 

Review-Url: https://codereview.webrtc.org/2709523003
Cr-Original-Commit-Position: refs/heads/master@{#16984}
Committed: https://chromium.googlesource.com/external/webrtc/+/c4e9d210b3516c7b2faa32f24409a2e626599255
Review-Url: https://codereview.webrtc.org/2709523003
Cr-Commit-Position: refs/heads/master@{#17024}
(cherry picked from commit ccf57a71eb2a550744367a4cbec285d85494c3c2)

Review-Url: https://codereview.webrtc.org/2748813002 .
Cr-Commit-Position: refs/branch-heads/58@{#2}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/BUILD.gn
[add] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper.cc
[add] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper.h
[add] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/blank_detector_desktop_capturer_wrapper_unittest.cc
[modify] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/rgba_color.h
[modify] https://crrev.com/c622c51234ae7fb0a0c6c45c74a8a8ee073482d5/webrtc/modules/desktop_capture/screen_capturer_win.cc

Status: Fixed (was: Started)
If there is no pending work please remove the label -  Merge-Approved-58
Labels: -Merge-Approved-58
Status: Verified (was: Fixed)
Verified fixed in 59.0.3071.115. Clicking Report an issue shows a correct screenshot.
Project Member

Comment 50 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d6987c5d68575b222ba9028802d47b889fd658

commit 96d6987c5d68575b222ba9028802d47b889fd658
Author: zijiehe <zijiehe@chromium.org>
Date: Tue Jul 25 21:32:32 2017

content/browser should depend on webrtc_overrides:init_webrtc

BlankDetectorDesktopCapturerWrapper needs to use HISTOGRAM in its
implementation. So content/browser needs to depend on init_webrtc target to get
histogram required components to be built in.
This should fix https://codereview.chromium.org/2709523003/ and
https://codereview.chromium.org/2725143004/.

BUG= 682112 

Review-Url: https://codereview.chromium.org/2731803002
Cr-Commit-Position: refs/heads/master@{#489442}

[modify] https://crrev.com/96d6987c5d68575b222ba9028802d47b889fd658/content/browser/BUILD.gn

Sign in to add a comment