Issue metadata
Sign in to add a comment
|
Regression: Security chip of extension name gets misplaced after crashing tab from task manager.
Reported by
dmascare...@etouch.net,
Jan 18 2017
|
||||||||||||||||||||
Issue descriptionChrome Version:57.0.2984.0 (Official Build) a2377c097a1fa051f90f9c02d96d010073fcb701-refs/heads/master@{#443964} OS: Windows (7,8,10),Linux What steps will reproduce the problem? 1. Launch chrome and navigate to https://chrome.google.com/webstore/detail/momentum/laookkfknpbbblfpciffpaejjkokdgca 2. Click on 'Add to chrome' such that NTP opens with the extension added (i.e. Security chip of extension name is seen on that NTP) 3. Press 'Shift+Esc' key from keyboard such that Task manager get open and select NTP with extension added option and click 'End process' 4. Observe. Actual:Security chip of extension name gets misplaced after crashing tab from task manager Expected:Security chip of extension name gets should not get misplaced after crashing tab from task manager This is regression issue, broken in 'M 57' and below is manual bisect info: Good build:57.0.2958.0 Bad build:57.0.2959.0 Note: Issue is not seen on Mac OS.
,
Jan 18 2017
Bisect Info: =========== Good build : 57.0.2957.0, Revision Range(439663) Bad build : 57.0.2959.0, Revision Range(440307) After executing the per-revision-bisect script, i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/41b288d33cad4776bc5f09ee435703a214449aaf..172e00cdced29d37051bd7fc8faaeedb7416653c The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/172e00cdced29d37051bd7fc8faaeedb7416653c Review URL --------------------------- https://codereview.chromium.org/2555063003 meacer@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Note: ------ In the good build, after loading extension, in the omnibox "i" in circle is displayed whereas in bad build, extension symbol is displayed along with its name.
,
Jan 23 2017
The problem here is not that we're choosing the wrong icon, it's that the icon is physically misaligned in this case. (It's too far to the left.) Definitely not working as intended :). Basically, the icon in question should be in the identical position, pixel-wise, when there's an extension name and when there's not; and the omnibox text should be in the same position as when we're showing the (i) icon.
,
Jan 23 2017
Ah right, didn't notice that the icon is moving further left. I'll take a look.
,
Jan 24 2017
The problem seems to be that IconLabelBubbleView::Layout assumes the bubble is being animated if the label is not shown. So it sets image_x to zero, moving the icon to left. @varkha: Does this assumption still hold if the bubble just doesn't show the label and only shows the image? (asking since you are the author of https://codereview.chromium.org/1763713004/diff/160001/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc). Thanks!
,
Jan 24 2017
What happens in the case where we're showing the (i) (i.e. there is no label)? Why doesn't that get similarly mispositioned?
,
Jan 24 2017
#5, if I read the current code correctly, when there is no label the icon is first allowed to slide all the way to the right and then when the right (trailing) edge of the icon is touching the trailing edge of the view the left (leading padding) starts to shrink until the view has the icon's width. I think when you don't have a label the view is allowed to shrink all the way to the icon's width (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc?sq=package:chromium&dr=CSs&rcl=1485202678&l=179) so the icon is taking all of the view and is put at x=0.
,
Feb 10 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest dev #58.0.3007.0 . meacer@ Ping! Could you please let us know is there any latest update available on this issue? Thanks!
,
Jun 23 2017
ping meacer@ per comment #5 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mea...@chromium.org
, Jan 18 2017