Issue metadata
Sign in to add a comment
|
interactive_ui_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) |
||||||||||||||||||||
Issue descriptioninteractive_ui_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) Type: build-failure Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Could it be affected by https://codereview.chromium.org/2636293002 "Fix MenuController Heap-use-after-free" Modifies ui/views/controls/menu/menu_controller.cc. Looks like a memory leak. BookmarkBarViewTest7.DNDToDifferentMenu (run #1): <truncated (442344 bytes)> 3da8e4 in SetIconView ui/views/controls/menu/menu_item_view.cc:400:5 #7 0x93da8e4 in views::MenuItemView::SetIcon(gfx::ImageSkia const&) ui/views/controls/menu/menu_item_view.cc:390 #8 0x93da2f6 in views::MenuItemView::AddMenuItemAt(int, int, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&, gfx::ImageSkia const&, views::MenuItemView::Type, ui::MenuSeparatorType) ui/views/controls/menu/menu_item_view.cc:257:11 #9 0x93db8cd in AppendMenuItemImpl ui/views/controls/menu/menu_item_view.cc:332:10 #10 0x93db8cd in views::MenuItemView::AppendSubMenuWithIcon(int, std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > const&, gfx::ImageSkia const&) ui/views/controls/menu/menu_item_view.cc:297 #11 0xf039a25 in BookmarkMenuDelegate::BuildMenu(bookmarks::BookmarkNode const*, int, views::MenuItemView*) chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc:544:31 #12 0xf03a19d in BookmarkMenuDelegate::CreateMenu(bookmarks::BookmarkNode const*, int, BookmarkMenuDelegate::ShowOptions) chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc:474:3 #13 0xf038f4c in BookmarkMenuDelegate::Init(views::MenuDelegate*, views::MenuItemView*, bookmarks::BookmarkNode const*, int, BookmarkMenuDelegate::ShowOptions, BookmarkLaunchLocation) chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc:110:13 #14 0xf037175 in BookmarkMenuController::BookmarkMenuController(Browser*, content::PageNavigator*, views::Widget*, bookmarks::BookmarkNode const*, int, bool) chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc:39:19 #15 0xf0234d2 in BookmarkBarView::OnMenuButtonClicked(views::MenuButton*, gfx::Point const&, ui::Event const*) chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1500:26 #16 0x9399082 in views::MenuButton::Activate(ui::Event const*) ui/views/controls/button/menu_button.cc:136:16 #17 0x939a305 in views::MenuButton::OnMouseReleased(ui::MouseEvent const&) ui/views/controls/button/menu_button.cc:221:5 #18 0x94dab74 in views::InkDropHostView::OnMouseEvent(ui::MouseEvent*) ui/views/animation/ink_drop_host_view.cc:262:9 #19 0xa952a59 in ui::ScopedTargetHandler::OnEvent(ui::Event*) ui/events/scoped_target_handler.cc:32:24 #20 0xa94b788 in DispatchEvent ui/events/event_dispatcher.cc:191:12 #21 0xa94b788 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139 #22 0xa94b19c in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14 #23 0xa94b19c in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58 #24 0x947da5c in views::internal::RootView::OnMouseReleased(ui::MouseEvent const&) ui/views/widget/root_view.cc:442:9 #25 0x94932f3 in views::Widget::OnMouseEvent(ui::MouseEvent*) ui/views/widget/widget.cc:1203:20 #26 0x94c5df9 in views::NativeWidgetAura::OnMouseEvent(ui::MouseEvent*) ui/views/widget/native_widget_aura.cc #27 0xa94b788 in DispatchEvent ui/events/event_dispatcher.cc:191:12 #28 0xa94b788 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139 #29 0xa94b19c in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14 #30 0xa94b19c in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58 #31 0xa94dc1e in ui::EventProcessor::OnEventFromSource(ui::Event*) ui/events/event_processor.cc:35:15 #32 0xa94ed9b in DeliverEventToProcessor ui/events/event_source.cc:73:21 #33 0xa94ed9b in ui::EventSource::SendEventToProcessor(ui::Event*) ui/events/event_source.cc:51 #34 0xbdba043 in aura::WindowTreeHostX11::DispatchEvent(_XEvent* const&) ui/aura/window_tree_host_x11.cc #35 0xa92cf95 in ui::PlatformEventSource::DispatchEvent(_XEvent*) ui/events/platform/platform_event_source.cc:81:29 #36 0xaa22e91 in ui::X11EventSource::ExtractCookieDataDispatchEvent(_XEvent*) ui/events/platform/x11/x11_event_source.cc:244:14 #37 0xaa22c49 in ui::X11EventSource::DispatchXEvents() ui/events/platform/x11/x11_event_source.cc:140:5 #38 0xaa2214b in ui::(anonymous namespace)::XSourceDispatch(_GSource*, int (*)(void*), void*) ui/events/platform/x11/x11_event_source_glib.cc:41:15 #39 0x7fb6b4f57d12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539 #40 0x7fb6b4f57d12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075 ----------------------------------------------------- Suppressions used: count bytes template 9 736 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 28864 byte(s) leaked in 118 allocation(s).
,
Jan 18 2017
,
Jan 18 2017
Revert in the queue in https://codereview.chromium.org/2638293002/
,
Jan 18 2017
,
Jan 18 2017
,
Jan 18 2017
,
Jan 18 2017
,
Jan 19 2017
,
Jan 19 2017
Hmm, review didnt post here. This was fixed by: https://codereview.chromium.org/2641983003/ |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by meade@chromium.org
, Jan 18 2017