MD Settings: Guest Mode bugs |
||||||||||
Issue descriptionMD Settings has some problems for Guest and Public Account sessions. The following issues are for Chrome OS Guest Mode: 1. Appearance: Fonts page shouldn't show "Advanced font settings" (guests can't install extensions) 2. Device > Storage: "Other users" links to /accounts, which doesn't exist in guest mode 3. Date and time: Time zone options should be disabled (guests can't change) 4. Date and time: "Set date and time" option should be hidden 5. Privacy and security: issue 681491 6. Privacy and security: Verified Access badge shows device owner instead of administrator (device has no owner) 7. Privacy and security: "Keep Wi-Fi on during sleep" probably should be hidden 8. Content settings: Some options don't work properly * For example, trying to block sites from setting cookies has no effect, but it works in Options * All these settings need auditing for guest mode 9. Clear browsing data: Some or all should be hidden for guest mode 10. Languages: Adding languages aren't reflected until page is reloaded 11. Accessibility: Manage sub-page should not show "Add additional features" (extensions can't be installed) Chrome OS Public Account sessions have most of the above issues, plus: 12. People section should be hidden: issue 657659 13. Appearance: Themes should be hidden (themes can't be installed) 14. On startup section should be hidden 15. Downloads: "Disconnect Google Drive account" should be hidden Chromium guest mode should also be audited.
,
Jan 18 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17b8c228ff69ac6dd875eac2bf81c0a96eb32c1c commit 17b8c228ff69ac6dd875eac2bf81c0a96eb32c1c Author: michaelpg <michaelpg@chromium.org> Date: Wed Jan 18 21:18:35 2017 MD Settings: Apply guest changes to public accounts Simple change to make public account sessions hide some Settings features the same way guest mode sessions do. BUG= 682107 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2639833003 Cr-Commit-Position: refs/heads/master@{#444483} [modify] https://crrev.com/17b8c228ff69ac6dd875eac2bf81c0a96eb32c1c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jan 19 2017
,
Jan 24 2017
,
Jan 25 2017
,
Jan 31 2017
Michael, are you planning to work on these? If not, please assign this to me.
,
Feb 1 2017
Re-assigned to stevenjb.
,
Feb 3 2017
For Guest Mode: 1. Appearance: Fonts page shouldn't show "Advanced font settings" (guests can't install extensions) Fix: hide row in guest mode. 2. Device > Storage: "Other users" links to /accounts, which doesn't exist in guest mode Fix: hide row in guest mode. 3. Date and time: Time zone options should be disabled (guests can't change) This has already been fixed. 4. Date and time: "Set date and time" option should be hidden Already fixed. 5. Privacy and security: issue 681491 Already fixed. 6. Privacy and security: Verified Access badge shows device owner instead of administrator (device has no owner) This only applies to unowned devices, issue 688471 7. Privacy and security: "Keep Wi-Fi on during sleep" probably should be hidden We set this when the pref changes, so even though it's not super useful, it is technically settable... 8. Content settings: Some options don't work properly * For example, trying to block sites from setting cookies has no effect, but it works in Options * All these settings need auditing for guest mode Created issue 688485 9. Clear browsing data: Some or all should be hidden for guest mode This appears to behave the same as current settings, it doesn't seem important to change it. 10. Languages: Adding languages aren't reflected until page is reloaded I'm unclear what this means, adding languages appears to work correctly in guest mode. 11. Accessibility: Manage sub-page should not show "Add additional features" (extensions can't be installed) Fix: hide row in guest mode.
,
Feb 3 2017
,
Feb 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/891c2c575f1da67a3e5886d536e671ef11142ae9 commit 891c2c575f1da67a3e5886d536e671ef11142ae9 Author: stevenjb <stevenjb@chromium.org> Date: Sat Feb 04 02:35:52 2017 MD Settings: Hide sections in guest mode BUG= 682107 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2676743003 Cr-Commit-Position: refs/heads/master@{#448151} [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/a11y_page/a11y_page.html [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/a11y_page/a11y_page.js [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/device_page/compiled_resources2.gyp [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/device_page/storage.html [modify] https://crrev.com/891c2c575f1da67a3e5886d536e671ef11142ae9/chrome/browser/resources/settings/device_page/storage.js
,
Feb 4 2017
,
Feb 22 2017
58.0.3015.0/9304.0.0 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by michae...@chromium.org
, Jan 18 2017