New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 682084 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

powerd_suspend doesn't power back on the modem on Blaze in case of suspend failure

Project Member Reported by benchan@chromium.org, Jan 18 2017

Issue description

crosreview.com/324106 modified powerd_suspend to power off the modem on Blaze before the system goes into suspend and then power the modem back on after the system successfully resumes from suspend. However, when powerd_suspend fails to update /sys/power/state, it doesn't power the modem back on, so the modem will stay powered off until the system is rebooted.

Regardless of whether powerd_suspend successfully updates /sys/power/state, it should power the modem back on if it did power the modem off.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/78a03311595600e9c25a103a949c39b52f5077f5

commit 78a03311595600e9c25a103a949c39b52f5077f5
Author: Ben Chan <benchan@chromium.org>
Date: Wed Jan 18 02:03:03 2017

power: power on modem on Blaze even in case of suspend failure

CL:324106 modified powerd_suspend to power off the modem on Blaze before
the system goes into suspend and then power the modem back on after the
system successfully resumes from suspend. However, when powerd_suspend
fails to update /sys/power/state, it doesn't power the modem back on, so
the modem will stay powered off until the system is rebooted. This CL
fixes this issue.

BUG= chromium:682084 
TEST=Verified that the ME936 modem on Blaze is powered back on even when
powerd_suspend fails to update /sys/power/state (by manually injected an
error in powerd_suspend).

Change-Id: Iea596358c0032a3590c49ad12d75e3c16fa74fbe
Reviewed-on: https://chromium-review.googlesource.com/429490
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/78a03311595600e9c25a103a949c39b52f5077f5/power_manager/powerd/powerd_suspend

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment