New issue
Advanced search Search tips

Issue 682082 link

Starred by 5 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 646062

Blocking:
issue 706860
issue 646062



Sign in to add a comment

Background blur performance test

Project Member Reported by reve...@chromium.org, Jan 18 2017

Issue description

Some form of UI performance test should be created to evaluate the background blur effect in the compositor and track improvements.
 
Blocking: 646062

Comment 2 by sky@chromium.org, Mar 30 2017

Blocking: 706860

Comment 3 by wutao@chromium.org, Jun 9 2017

Cc: wutao@chromium.org reve...@chromium.org
 Issue 730841  has been merged into this issue.

Comment 4 by wutao@chromium.org, Jun 9 2017

Labels: -Pri-3 Pri-2
Owner: wutao@chromium.org
A cl was uploaded: https://codereview.chromium.org/2932503003/

Comment 6 by wutao@chromium.org, Sep 13 2017

Blockedon: 646062
Labels: M-64 M-63
Tests to add for M63:
1. Need to add foreground blur perf test.
2. Need to add cache render surface to foreground blur to see the improvement.

Possible for M64:
After the new background blur mechanism launched, need to compare with current method and used combine with cache render surface.
Are these resolved? Should these be closed?

Comment 8 by wutao@chromium.org, Mar 9 2018

Labels: -Pri-2 Pri-3
This is still available.
There are more tests need to be added for missing Chrome UI performance tests for layer blur effect.

Comment 9 by wutao@chromium.org, Mar 9 2018

Components: OS>Performance
Status: Assigned (was: Available)
Owner: dcasta...@chromium.org
Assign to dcastagna@ for new implementation.

Cc: -reve...@chromium.org dcasta...@chromium.org
Owner: andrescj@chromium.org
Assigning it back to Andres that worked on crrev.com/c/1324240
Cc: andrescj@chromium.org
 Issue 902907  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4dbee64ff71d059e42fe7af075e2d2e5729a78

commit 5e4dbee64ff71d059e42fe7af075e2d2e5729a78
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Wed Dec 12 21:33:06 2018

Create a story to detect blur backdrop filter regressions.

This CL creates a story which consists of a JS animation in which a
group of red squares rotates in the background while three
semi-transparent foregrounds move on top (with some rotation,
translation, and resizing going on). The foregrounds apply a blur
filter.

The motivation is that in Chrome OS, we were having problems with the
launcher animation having a low frame rate. As the launcher is swiped
upwards, it applies a blur on the background. dcastagna@ landed a fix to
improve this significantly (see  https://crbug.com/900046 ). The code used
by the launcher to do the blurring is not unique to Chrome OS, so the
new story should be able to measure regressions in that animation.

For due credit: the story is based on tbuckley@'s example which
reproduced the issue on the web (see
https://codepen.io/anon/pen/MPXYMQ).

Chromebook after reverting bf7c381 (dcastagna@'s fix) from 96c5b05.

Test: percentage_smooth goes from 90.805% to 36.158% on an eve
Bug: 682082
Change-Id: Ifc4a725a2ba430e7698fccde703d2de4a12db687
Reviewed-on: https://chromium-review.googlesource.com/c/1324240
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616050}
[modify] https://crrev.com/5e4dbee64ff71d059e42fe7af075e2d2e5729a78/tools/perf/benchmark.csv
[add] https://crrev.com/5e4dbee64ff71d059e42fe7af075e2d2e5729a78/tools/perf/page_sets/backdrop_filter_cases/blur_rotating_background.html
[add] https://crrev.com/5e4dbee64ff71d059e42fe7af075e2d2e5729a78/tools/perf/page_sets/rendering/backdrop_filter_cases.py
[modify] https://crrev.com/5e4dbee64ff71d059e42fe7af075e2d2e5729a78/tools/perf/page_sets/rendering/rendering_stories.py
[modify] https://crrev.com/5e4dbee64ff71d059e42fe7af075e2d2e5729a78/tools/perf/page_sets/rendering/story_tags.py

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/43ff6a9e662219e91c474c279cb931971ff7f978

commit 43ff6a9e662219e91c474c279cb931971ff7f978
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Fri Dec 14 23:04:36 2018

Enable rendering.desktop/backdrop_filter test in CrOS.

This CL ensures that the rendering.desktop/backdrop_filter runs in CrOS
so that we can detect regressions of the launcher animation which may
involve background blurring.

TEST=ran run_benchmark with the modified story_tag_filter argument.
BUG=chromium:682082

Change-Id: Ic7ce0589866f4b7ee1b0ac1553fec03fc98d7a7a
Reviewed-on: https://chromium-review.googlesource.com/c/1378927
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/43ff6a9e662219e91c474c279cb931971ff7f978/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py
[modify] https://crrev.com/43ff6a9e662219e91c474c279cb931971ff7f978/server/site_tests/telemetry_Benchmarks/control.rendering.desktop

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7b73266c3af7214d6dfac434f09218fe93ef6abb

commit 7b73266c3af7214d6dfac434f09218fe93ef6abb
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Sat Dec 15 02:06:05 2018

Put the backdrop_filter perf test in a separate control file.

This CL creates control.backdrop_filter.renderer.desktop so that the
backdrop_filter stories can run independently of other rendering.desktop
stories since the browser needs to have the
--enable-experimental-web-platform-features flag. The new file is
unmanaged by generate_controlfiles.py but is based on the existing
control.rendering.desktop file.

TEST=run_benchmark with --story-tag-filter=backdrop_filter runs as
expected.
BUG=chromium:682082

Change-Id: I6360fc09282750bea6257679cc51f230e20deee1
Reviewed-on: https://chromium-review.googlesource.com/c/1378928
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[add] https://crrev.com/7b73266c3af7214d6dfac434f09218fe93ef6abb/server/site_tests/telemetry_Benchmarks/control.backdrop_filter.rendering.desktop
[modify] https://crrev.com/7b73266c3af7214d6dfac434f09218fe93ef6abb/server/site_tests/telemetry_Benchmarks/control.rendering.desktop
[modify] https://crrev.com/7b73266c3af7214d6dfac434f09218fe93ef6abb/server/site_tests/telemetry_Benchmarks/generate_controlfiles.py

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9821dd42f2e4cd6d65485d35cc4b4b907135e9d8

commit 9821dd42f2e4cd6d65485d35cc4b4b907135e9d8
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Wed Dec 19 09:12:43 2018

Make backdrop_filter.rendering.desktop report to perf dashboard.

This CL makes it so that the results of the
telemetry_Benchmarks.backdrop_filter.rendering.desktop test are reported
in the perf dashboard.

TEST=not needed.
BUG=chromium:682082

Change-Id: I9a7fb40338c40d89f4d6147ad5a2a467447effcd
Reviewed-on: https://chromium-review.googlesource.com/1383073
Commit-Ready: Andres Calderon Jaramillo <andrescj@chromium.org>
Tested-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/9821dd42f2e4cd6d65485d35cc4b4b907135e9d8/tko/perf_upload/perf_dashboard_config.json

Sign in to add a comment