New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 682068 link

Starred by 2 users
Status: Assigned
Owner:
einbinder@chromium.org
Cc:
█ marcy.su...@deque.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Devtools] Tab switching shortcut conflicts with browser back shortcut on Mac when switching away from extension panels

Project Member Reported by aboxhall@chromium.org, Jan 18 2017 
https://developers.google.com/web/tools/chrome-devtools/shortcuts ->

Previous panel: Cmd + [ 

https://support.google.com/chrome/answer/157179?hl=en

Mac:
Open the previous page in your browsing history for the current tab:
	⌘ + [ or ⌘ + Left arrow

This means that switching tabs in devools via shortcut on mac also navigates the page, causing loss of context.

This only seems to happen when switching between built-in and extension panels.

(Via Marcy Sutton)

Comment 1 by marcy.su...@deque.com, Jan 18 2017 

I recorded a screencast of this behavior, reproducible with and without Voiceover running. It happens when the user is navigating through devtools tabs using the Mac shortcuts ⌘ + [ or ⌘ + ], without focusing in the content area at all. It does seem isolated to extension panels, and not built-in ones.

It becomes very problematic for a blind Voiceover user trying to run an accessibility audit on a particular webpage using an extension. If devtools tabs can only be accessed by that conflicting keyboard shortcut and the page is changing at the same time, they will run into trouble.
chrome-tabs-bug.mp4
11.9 MB View Download

Comment 2 by caseq@chromium.org, Jan 20 2017

Owner: caseq@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by pfeldman@chromium.org, Oct 4 2017

Status: Archived (was: Assigned)
Bulk DevTools triage, closing low priority issues with no action plan.

Comment 4 by aboxhall@chromium.org, Oct 17 2017

Owner: einbinder@chromium.org
Status: Assigned (was: Archived)
Re-opening and assigning to Joel as this is still an issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9714881871a256c98e5b12651aedd5210319ef36

commit 9714881871a256c98e5b12651aedd5210319ef36
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Aug 02 00:33:47 2018

DevTools: Prevent browser behavior of shortcuts in extension panels

This patch calls preventDefault on all events that we forward from
extension panels into devtools. This would cancel too many events,
so a list of devtools global keyboard shortcuts are passed into the
extension.

Bug: 682068
Change-Id: Ide557dafed759e20dfc6698d8cdc33f932acbe83
Reviewed-on: https://chromium-review.googlesource.com/1159467
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580011}
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/WebKit/LayoutTests/http/tests/devtools/extensions/extensions-panel.js
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/blink/renderer/devtools/front_end/extensions/ExtensionAPI.js
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/blink/renderer/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/blink/renderer/devtools/front_end/main/module.json
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/blink/renderer/devtools/front_end/ui/InspectorView.js
[modify] https://crrev.com/9714881871a256c98e5b12651aedd5210319ef36/third_party/blink/renderer/devtools/front_end/ui/ShortcutRegistry.js

Comment 6 by einbinder@chromium.org, Aug 2 

Should be fixed in the next Canary version.
►

Sign in to add a comment