Issue 682058 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	----
Closed:	Jan 2017
Cc:	█ shchen@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-59 VerifyIn-60 VerifyIn-61

vboot_reference compile error with DEBUG=1

Project Member Reported by rspangler@chromium.org, Jan 18 2017

Issue description

Build vboot_reference with DEBUG=1:

DEBUG=1 make runtests
DEBUG=1 emerge-reef vboot_reference

These fail because printf() is not defined in some files like vboot_audio.c, and the hostlib extern linktest links against the vboot1 stub functions but not the vboot2 stub functions.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/e02a19a6c26259c40d655665e990cc4dbee46dc1

commit e02a19a6c26259c40d655665e990cc4dbee46dc1
Author: Randall Spangler <rspangler@chromium.org>
Date: Wed Jan 18 00:36:34 2017

vboot: fix compiling with DEBUG=1

If FOR_TEST is defined, 2common.h defines VB2_DEBUG() to be printf();
it should include stdio.h as well.

The HOSTLIB extern linktest links against the vboot1 stub functions,
but not the vboot2 stub functions, so it couldn't find vb2ex_printf().

BUG= chromium:682058 
BRANCH=none
TEST=DEBUG=1 make runtests; DEBUG=1 emerge-reef vboot_reference depthcharge

Change-Id: Ibf981a70ca4087ce3d86b02d76e03063b2cfc9e5
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/429310
Commit-Ready: Shelley Chen <shchen@chromium.org>
Reviewed-by: Shelley Chen <shchen@chromium.org>

[modify] https://crrev.com/e02a19a6c26259c40d655665e990cc4dbee46dc1/Makefile
[modify] https://crrev.com/e02a19a6c26259c40d655665e990cc4dbee46dc1/firmware/2lib/include/2common.h