New issue
Advanced search Search tips

Issue 682052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 629181



Sign in to add a comment

Ensure WebAPKs are marked as important storage when added from the menu

Project Member Reported by sbirch@chromium.org, Jan 18 2017

Issue description

WebAPKs should be recording the app banner DID_ADD_TO_HOMESCREEN event
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88a9a4f79d7fe6b05b2def6cbf158c935b1040b1

commit 88a9a4f79d7fe6b05b2def6cbf158c935b1040b1
Author: dominickn <dominickn@chromium.org>
Date: Wed Jan 18 01:20:11 2017

Ensure WebAPK installation always records the app banner installation event.

WebAPKs should always record the app banner DID_ADD_TO_HOMESCREEN event,
which ensures that no banners are shown for an installed WebAPK and that
an installed WebAPK is regarded as an important site.

crrev.com/2473243002 erroneously stopped WebAPKs installed from the add
to homescreen menu item from recording the event. This CL addresses the
issue.

BUG= 682052 

Review-Url: https://codereview.chromium.org/2638213002
Cr-Commit-Position: refs/heads/master@{#444222}

[modify] https://crrev.com/88a9a4f79d7fe6b05b2def6cbf158c935b1040b1/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Owner: dominickn@chromium.org
Status: Fixed (was: Available)

Comment 3 by sbirch@chromium.org, Jan 18 2017

Awesome! Thanks Dom.

Sign in to add a comment