New issue
Advanced search Search tips

Issue 682049 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: bad indentation after turning on timestamp with repeated messages

Project Member Reported by l...@chromium.org, Jan 18 2017 
- Open DevTools console
- Make some repeated messages, e.g.
for (var i = 0; i < 10; i++) console.log(5)

- Turn on 'show timestamps' from Settings

See screenshot for bad indentation.

We're not removing the repeated-message class when we reset the repeat counter.
badTimestampIndent.png
7.9 KB View Download

Comment 1 by l...@chromium.org, Jan 24 2017

Components: -Platform>Apps>DevTools Platform>DevTools
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674aa2e6ff1a72c7a427ef033cc75e48cc61876

commit d674aa2e6ff1a72c7a427ef033cc75e48cc61876
Author: luoe <luoe@chromium.org>
Date: Mon Jan 30 21:17:11 2017

DevTools: update console timestamp style

A few bugs with console timestamps are addressed:
- All messages get timestamps; previously, commands/evaluations did not.
- Timestamps should not wrap
- Turning on timestamps should remove the repeated-message class
- New setting to choose [none, full timestamp, short timestamp (no yy:mm:dd)]

With the addition of a new setting, users who previously had timestamps enabled
will be migrated to the short format by default.

BUG= 651927 ,  678585 ,  682049 

Review-Url: https://codereview.chromium.org/2651843003
Cr-Commit-Position: refs/heads/master@{#447065}

[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp-expected.txt
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d674aa2e6ff1a72c7a427ef033cc75e48cc61876

commit d674aa2e6ff1a72c7a427ef033cc75e48cc61876
Author: luoe <luoe@chromium.org>
Date: Mon Jan 30 21:17:11 2017

DevTools: update console timestamp style

A few bugs with console timestamps are addressed:
- All messages get timestamps; previously, commands/evaluations did not.
- Timestamps should not wrap
- Turning on timestamps should remove the repeated-message class
- New setting to choose [none, full timestamp, short timestamp (no yy:mm:dd)]

With the addition of a new setting, users who previously had timestamps enabled
will be migrated to the short format by default.

BUG= 651927 ,  678585 ,  682049 

Review-Url: https://codereview.chromium.org/2651843003
Cr-Commit-Position: refs/heads/master@{#447065}

[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp-expected.txt
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/LayoutTests/inspector/console/console-timestamp.html
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d674aa2e6ff1a72c7a427ef033cc75e48cc61876/third_party/WebKit/Source/devtools/front_end/platform/utilities.js

Comment 4 by l...@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment