New issue
Advanced search Search tips

Issue 682042 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Add offline bots to /trooper

Project Member Reported by zhangtiff@chromium.org, Jan 17 2017

Issue description

Offline bots are counted separately from infra failures and they're generally handled by troopers, so it makes sense to move these over to the trooper tab. 

Not sure if we want to hide them from sheriffs or not though? I think at least one sheriffing survey response mentioned that offline bots were stressful to see on Sheriff-o-Matic, but I'd want to make sure there's not a good reason to make sure they're readily visible. 
 
Makes sense. 

Sheriffs should still be aware of them since it affects their work, but they should appear as alerts. Maybe more like warnings, similar to how we display a notice when a master is restarting. 

And if the trooper has linked a bug or commented, that should appear in the notice too. But it shouldn't render like an alert to sheriffs, with the calls-to-action etc.
Status: Started (was: Untriaged)
Huh, Bugdroid didn't link this CL: https://chromium-review.googlesource.com/c/435481/

Anyways, this is deployed now though I think there is still more to do here. 

I think maybe leaving the full annotation capabilities for sheriffs should be fine just in case they do want to use bugs or comments to communicate? (ie: see an offline bot, request a master restart, link the master restart bug to the alert). As long as there's a note that these are the duty of troopers, I think that should be fine. 
Can you file a bug for the missing bugdroid comment? That indicates a
problem we should look into ...
(in #2 I meant "but they should *not* appear as alerts")

yeah bugdroid is being weird lately :/

How about leaving off the annotation actions, but linking to the /trooper view of the examine page for the alert, which *does* have all of the annotation actions?

Just a thought. If we show those buttons next to a thing, sheriffs may feel like they're responsible for taking action on it. 
I filed a bug for the missing Bugdroid comment: https://bugs.chromium.org/p/chromium/issues/detail?id=687696 Seems a few other people have noticed this, too. 

That makes sense. I think that would be fine, and you have a good point. Or maybe we could leave out snooze and link bug, but keep comments and maybe change the UI for comments to say something like "Add a note for the trooper" 

These are also good ideas for how to display general infra failures to sheriffs as well. 
Status: Fixed (was: Started)
I think offline bots have counted as trooper failures for a while now. 

Sign in to add a comment