Issue metadata
Sign in to add a comment
|
browser_tests failing on chromium.win/Win7 Tests (dbg)(1) |
||||||||||||||||||||
Issue descriptionbrowser_tests failing on chromium.win/Win7 Tests (dbg)(1) Type: build-failure Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29
,
Jan 18 2017
flaky: 2/5 failures of this test since landing: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56550 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56547 (patch included in this run) Log: PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin (run #1): [ RUN ] PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin [6360:2024:0117/145721.111:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: Background [6360:2024:0117/145721.626:WARNING:chrome_browser_main_win.cc(425)] Command line too long for RegisterApplicationRestart [6004:6512:0117/145722.439:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported. [6360:7032:0117/145723.632:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico c:\c\win\src\chromerowser\plugins\plugin_power_saver_browsertest.cc(632): error: Value of: tab_specific_content_settings->blocked_plugin_names().empty() Actual: true Expected: false [6360:2024:0117/145724.249:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin, where TypeParam = and GetParam() = (3321 ms)
,
Jan 18 2017
Reassigning to CL author; not sure why this was assigned to me.
,
Jan 18 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/849cf351ba77ea929f2d850f5df99ca2fbdcb6b0 commit 849cf351ba77ea929f2d850f5df99ca2fbdcb6b0 Author: meade <meade@chromium.org> Date: Wed Jan 18 01:26:12 2017 Disable PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin on windows due to flakiness BUG= 682039 TBR=skyostil@chromium.org Review-Url: https://codereview.chromium.org/2637313003 Cr-Commit-Position: refs/heads/master@{#444226} [modify] https://crrev.com/849cf351ba77ea929f2d850f5df99ca2fbdcb6b0/chrome/browser/plugins/plugin_power_saver_browsertest.cc
,
Jan 18 2017
Removing from sheriff queue
,
Jan 18 2017
The said CL shouldn't affect platforms other than Linux. It seems the said test was already flaky before the said CL. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PluginPowerSaverFilterSameOriginTinyPluginsBrowserTest.BlockSameOriginTinyPlugin
,
Jan 25 2017
As (previous) sheriff, I have no idea what to do about flaky tests other than disable them. Please assign to someone who can actually do something. Thanks.
,
Jan 25 2017
According to git blame, this test was added by tommycli@. meade@, next time, as a developer who disabled a flaky test, please be responsible to find an appropriate owner to fix the test.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e510ebfc9f8565fc8cec92955b631aae49c17fd3 commit e510ebfc9f8565fc8cec92955b631aae49c17fd3 Author: tommycli <tommycli@chromium.org> Date: Thu Apr 20 20:59:48 2017 Plugin Power Saver: Remove racy portion of tests. The removed lines are racy, since it's possible that sometimes the browser process has not received the 'blocked plugin' message from the renderer yet. It would be pretty tricky to coordinate, and I think not worth it. This test should focus on the PPS aspects specifically anyways. BUG= 682039 , 680544 Review-Url: https://codereview.chromium.org/2831003003 Cr-Commit-Position: refs/heads/master@{#466126} [modify] https://crrev.com/e510ebfc9f8565fc8cec92955b631aae49c17fd3/chrome/browser/plugins/plugin_power_saver_browsertest.cc
,
Apr 20 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by meade@chromium.org
, Jan 18 2017