New issue
Advanced search Search tips

Issue 682023 link

Starred by 1 user
Status: Fixed
Owner:
boliu@chromium.org
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

BrowserMessageFilter::ShutdownForBadMessage doesn't work for single process

Project Member Reported by boliu@chromium.org, Jan 17 2017 
specifically on android, where there is no child service to stop, so basically nothing happens in that method.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e846547dbff976d7758b59d836f3573e4446c32

commit 1e846547dbff976d7758b59d836f3573e4446c32
Author: boliu <boliu@chromium.org>
Date: Mon Jan 23 18:56:34 2017

Crash for bad message in BrowserFilter

This matches behavior in RenderProcessHostImpl::ShutdownForBadMessage.
This is particularly important on android, where in-process gpu and
renderers are used in production, and ChildProcessLauncher does not
support killing the browser process.

Note, not using run_renderer_in_process() check because BrowserFilter
may be used for other types of child processes.

BUG= 682023 

Review-Url: https://codereview.chromium.org/2640083002
Cr-Commit-Position: refs/heads/master@{#445421}

[modify] https://crrev.com/1e846547dbff976d7758b59d836f3573e4446c32/content/public/browser/browser_message_filter.cc

Comment 2 by boliu@chromium.org, Jan 23 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment