New issue
Advanced search Search tips

Issue 682022 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add DataReductionProxy UMA on page size usage

Project Member Reported by ryansturm@chromium.org, Jan 17 2017

Issue description

UMA should be added to Page_load_metrics (data_reduction_proxy observer) to track the per-page data usage of data reduction proxy along with information about compression of the page.
 

Comment 1 by ajha@chromium.org, Jan 18 2017

Just to update, M-57 gets branched tomorrow and would probably go to Beta during 1st week of Feb.

Please adjust or update the blocker and milestone accordingly.
Thanks, this is in reviews, and can hopefully land before branch or merge back shortly after.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/485df9ed214f7924eaf8ed067070146e3d12aa58

commit 485df9ed214f7924eaf8ed067070146e3d12aa58
Author: ryansturm <ryansturm@chromium.org>
Date: Thu Jan 19 22:17:24 2017

Adding UMA for data reduction proxy page load size/savings

This Adds UMA to track bytes savings, percent savings, total requests,
percent requests throug the proxy, byte usage, etc.

This UMA will be compared against existing PLM data as well as sliced by
various experiments in data reduction proxy.

BUG= 682022 

Review-Url: https://codereview.chromium.org/2642553002
Cr-Commit-Position: refs/heads/master@{#444859}

[modify] https://crrev.com/485df9ed214f7924eaf8ed067070146e3d12aa58/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/485df9ed214f7924eaf8ed067070146e3d12aa58/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/485df9ed214f7924eaf8ed067070146e3d12aa58/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/485df9ed214f7924eaf8ed067070146e3d12aa58/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 3 2017

Labels: -Merge-TBD

Sign in to add a comment