New issue
Advanced search Search tips

Issue 682011 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623160



Sign in to add a comment

Convert AudioNode tests to use testharness

Project Member Reported by rtoy@chromium.org, Jan 17 2017

Issue description

Convert AudioNode tests to use testharness when possible.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a29620cf841e864eefd270fd8d5ecb7e673eb0

commit 15a29620cf841e864eefd270fd8d5ecb7e673eb0
Author: rtoy <rtoy@chromium.org>
Date: Tue Jan 24 18:44:32 2017

Convert AudioNode Audit tests to testharness

These tests were converted using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

audionode-disconnect-audioparam.html required some manual adjustments
because it used testPassed directly.

BUG= 682011 
TEST=audionode-connect-method-chaining.html,audionode-disconnect-audioparam.html,audionode-disconnect.html

Review-Url: https://codereview.chromium.org/2638203002
Cr-Commit-Position: refs/heads/master@{#445766}

[delete] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining-expected.txt
[modify] https://crrev.com/15a29620cf841e864eefd270fd8d5ecb7e673eb0/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining.html
[delete] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-audioparam-expected.txt
[modify] https://crrev.com/15a29620cf841e864eefd270fd8d5ecb7e673eb0/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-audioparam.html
[delete] https://crrev.com/f8344f4e824e081eadcc29b79edaa40dbdfef3b4/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-expected.txt
[modify] https://crrev.com/15a29620cf841e864eefd270fd8d5ecb7e673eb0/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89cb5871b5678f3931845d58bab298e46ae5e64b

commit 89cb5871b5678f3931845d58bab298e46ae5e64b
Author: rtoy <rtoy@chromium.org>
Date: Fri Jan 27 20:16:38 2017

Convert more AudioNode tests to use testharness

Manually convert the tests to use testharness.  Since we need to
replace the js-test stuff as well, the file was converted to use new
Audit too.

BUG= 682011 
TEST=audionode.html, audionode-channel-rules.html, audionode-connect-order.html

Review-Url: https://codereview.chromium.org/2651623004
Cr-Commit-Position: refs/heads/master@{#446747}

[delete] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-channel-rules-expected.txt
[modify] https://crrev.com/89cb5871b5678f3931845d58bab298e46ae5e64b/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-channel-rules.html
[delete] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-order-expected.txt
[modify] https://crrev.com/89cb5871b5678f3931845d58bab298e46ae5e64b/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-order.html
[delete] https://crrev.com/6e6c4d244253b5a5339a97fc9d8a5bfb3d7aa127/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-expected.txt
[modify] https://crrev.com/89cb5871b5678f3931845d58bab298e46ae5e64b/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html

Comment 3 by rtoy@chromium.org, Feb 1 2017

Owner: rtoy@chromium.org
Status: Started (was: Available)

Comment 4 by rtoy@chromium.org, Mar 9 2017

Status: Fixed (was: Started)
There is one remaining test to convert here and https://codereview.chromium.org/2717723002/ is the CL for that.  It fails on windows and I don't know why.  It seems unlikely this test (as is) will ever become a web platform test, so we're not going to do anything about this.

Closing as fixed.

Sign in to add a comment