New issue
Advanced search Search tips

Issue 682002 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 368813



Sign in to add a comment

Convert remaining users of deprecated WebContentsObserver navigation methods

Project Member Reported by jam@chromium.org, Jan 17 2017

Issue description

The reasons are:
1) decrease risk of features (which don't have tests) breaking in canary experiment.
2) allow us to remove the old methods

One thing I've found by looking at some unit tests is that some of them use test harnesses which don't really reflect how things happen in practice. As such, they might fire only the old callbacks or the new ones, depending on the PlzNavigate mode. It looks difficult to change the test harnesses, so I'm focusing on having both code paths in these few tests and then we can delete the old methods when switching over. That way there's no extra work when we want to switch the code to PlzNavigate. If these tests are the only remaining users of the deprecated methods, we can use hacks like private methods and friend statements to ensure no more creep in.
 

Comment 1 by jam@chromium.org, Jan 18 2017

btw for anyone looking at this bug from linked cls, this doc describes the new callbacks
https://docs.google.com/document/d/1HTLT1PI2LiS7rh29eW2OSh2zG-xqFEynv-T7vn39OLc/edit?ts=58659ed5
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a88c6be00c8a4beb0be24791c9f6812cc78a94d

commit 9a88c6be00c8a4beb0be24791c9f6812cc78a94d
Author: jam <jam@chromium.org>
Date: Wed Jan 18 16:06:08 2017

Convert OverscrollNavigationOverlayTest.ImmediateLoadOnNavigate to use the new navigation callbacks with PlzNavigate.

The unit test harness is not very realistic, so it doesn't send the new callbacks when PlzNavigate isn't enabled. So I've added both methods and I'm using each of them depending on the mode.

This test also exposed some UAFs that occur if an observer resets the NavigationRequest synchronously during its creation. I've added code to guard against this.

BUG= 682002 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2639073002
Cr-Commit-Position: refs/heads/master@{#444377}

[modify] https://crrev.com/9a88c6be00c8a4beb0be24791c9f6812cc78a94d/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/9a88c6be00c8a4beb0be24791c9f6812cc78a94d/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/9a88c6be00c8a4beb0be24791c9f6812cc78a94d/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa90ea1cec4f6bcc64a494c9a150e16f0e01c508

commit aa90ea1cec4f6bcc64a494c9a150e16f0e01c508
Author: jam <jam@chromium.org>
Date: Fri Jan 20 06:08:44 2017

Convert SessionCrashedBubbleView to use the new navigation callbacks.

In this specific case, I didn't see a reason that two callbacks are needed. Note that also DidStartNavigationToPendingEntry is skipped for the initial NTP navigation since it happens before this WebContentObserver is added to the first tab. However DidStartNavigation has different timing and would be reached for the NTP.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2641813004
Cr-Commit-Position: refs/heads/master@{#444993}

[modify] https://crrev.com/aa90ea1cec4f6bcc64a494c9a150e16f0e01c508/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/aa90ea1cec4f6bcc64a494c9a150e16f0e01c508/chrome/browser/ui/views/session_crashed_bubble_view.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 20 2017

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f174850ffb24a21a76cd786551203c26a47b97d4

commit f174850ffb24a21a76cd786551203c26a47b97d4
Author: jam <jam@chromium.org>
Date: Fri Jan 20 19:01:41 2017

Convert tests to use the non-deprecated WebContentsObserver navigation methods.

Some unit tests use a harness that is not very realistic, so it doesn't send the new callbacks when PlzNavigate isn't enabled. In those cases I've added both methods and I'm using each of them depending on the mode. This makes it trivial to delete the old code path when switching PlzNavigate on and deleting the old methods, instead of having to update the tests then.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2640473003
Cr-Commit-Position: refs/heads/master@{#445115}

[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/chrome/browser/ui/browser_instant_controller_unittest.cc
[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/f174850ffb24a21a76cd786551203c26a47b97d4/content/browser/web_contents/web_contents_view_aura_browsertest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34daea6e90246c16505840ff3d75991ef34e8a2d

commit 34daea6e90246c16505840ff3d75991ef34e8a2d
Author: jam <jam@chromium.org>
Date: Wed Jan 25 00:51:37 2017

Convert MimeHandlerStreamManager to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2652903002
Cr-Commit-Position: refs/heads/master@{#445884}

[modify] https://crrev.com/34daea6e90246c16505840ff3d75991ef34e8a2d/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5fa84704f2917edc43a1f4c5a827b65e25d867

commit 3a5fa84704f2917edc43a1f4c5a827b65e25d867
Author: jam <jam@chromium.org>
Date: Wed Jan 25 01:22:37 2017

Convert ExtensionWebUiTimer to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2656483004
Cr-Commit-Position: refs/heads/master@{#445897}

[modify] https://crrev.com/3a5fa84704f2917edc43a1f4c5a827b65e25d867/chrome/browser/ui/webui/extensions/extensions_ui.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 26 2017

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a43bf0c840d6d4c573e3847e4359698f61920978

commit a43bf0c840d6d4c573e3847e4359698f61920978
Author: jam <jam@chromium.org>
Date: Fri Jan 27 01:13:31 2017

Convert CrossSiteRedirectorBrowserTest to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2652413003
Cr-Commit-Position: refs/heads/master@{#446516}

[modify] https://crrev.com/a43bf0c840d6d4c573e3847e4359698f61920978/content/test/browser_test_utils_browsertest.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec320f452b4ca33c8735cb20f178267977a431ba

commit ec320f452b4ca33c8735cb20f178267977a431ba
Author: jam <jam@chromium.org>
Date: Fri Jan 27 01:18:06 2017

Convert Distiller browser test to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2650653008
Cr-Commit-Position: refs/heads/master@{#446519}

[modify] https://crrev.com/ec320f452b4ca33c8735cb20f178267977a431ba/components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80cd4e0be56d5861cd75ee70197be02c18d5217e

commit 80cd4e0be56d5861cd75ee70197be02c18d5217e
Author: jam <jam@chromium.org>
Date: Fri Jan 27 01:19:29 2017

Convert NavigationControllerBrowserTest to use the new navigation callbacks.

BUG= 682002 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2662463002
Cr-Commit-Position: refs/heads/master@{#446520}

[modify] https://crrev.com/80cd4e0be56d5861cd75ee70197be02c18d5217e/content/browser/frame_host/navigation_controller_impl_browsertest.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45fe549bd741139e0b64d4a90130642ed5407c77

commit 45fe549bd741139e0b64d4a90130642ed5407c77
Author: jam <jam@chromium.org>
Date: Fri Jan 27 03:01:27 2017

Convert service_worker_client_utils to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2656163004
Cr-Commit-Position: refs/heads/master@{#446557}

[modify] https://crrev.com/45fe549bd741139e0b64d4a90130642ed5407c77/content/browser/service_worker/service_worker_client_utils.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984f50b22fe3337804670907f0cb51ae6539b17f

commit 984f50b22fe3337804670907f0cb51ae6539b17f
Author: jam <jam@chromium.org>
Date: Fri Jan 27 21:27:13 2017

Convert DriveWebContentsManager to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2658203002
Cr-Commit-Position: refs/heads/master@{#446778}

[modify] https://crrev.com/984f50b22fe3337804670907f0cb51ae6539b17f/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f998a5e1f13847384ddc3574d549b2759fcca04c

commit f998a5e1f13847384ddc3574d549b2759fcca04c
Author: jam <jam@chromium.org>
Date: Fri Jan 27 22:18:02 2017

Convert NavigationControllerBrowserTest to use the new navigation callbacks.

BUG= 682002 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2662533002
Cr-Commit-Position: refs/heads/master@{#446790}

[modify] https://crrev.com/f998a5e1f13847384ddc3574d549b2759fcca04c/content/browser/frame_host/navigation_controller_impl_browsertest.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/506c250363a28b39338e69aaa50bc83707fe5767

commit 506c250363a28b39338e69aaa50bc83707fe5767
Author: jam <jam@chromium.org>
Date: Fri Jan 27 23:13:08 2017

Convert SelfDeletingRequestDelegate to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2659953002
Cr-Commit-Position: refs/heads/master@{#446818}

[modify] https://crrev.com/506c250363a28b39338e69aaa50bc83707fe5767/chrome/browser/dom_distiller/tab_utils.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcc6272584a2bd337ad4e3540b62788e6509dff

commit edcc6272584a2bd337ad4e3540b62788e6509dff
Author: jam <jam@chromium.org>
Date: Fri Jan 27 23:19:12 2017

Convert DevToolsUIBindingsEnabler to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2657313002
Cr-Commit-Position: refs/heads/master@{#446823}

[modify] https://crrev.com/edcc6272584a2bd337ad4e3540b62788e6509dff/chrome/browser/ui/webui/inspect_ui.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db083e38d3c9c61b3b0d3f1b1eebed7d62f7b062

commit db083e38d3c9c61b3b0d3f1b1eebed7d62f7b062
Author: jam <jam@chromium.org>
Date: Sat Jan 28 00:31:34 2017

Convert DevToolsUIBindings to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2660713002
Cr-Commit-Position: refs/heads/master@{#446849}

[modify] https://crrev.com/db083e38d3c9c61b3b0d3f1b1eebed7d62f7b062/chrome/browser/devtools/devtools_ui_bindings.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d41c4f901f69a8cc900f143fa67b05381a12e2f

commit 8d41c4f901f69a8cc900f143fa67b05381a12e2f
Author: jam <jam@chromium.org>
Date: Mon Jan 30 20:47:44 2017

Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2660643003
Cr-Commit-Position: refs/heads/master@{#447056}

[modify] https://crrev.com/8d41c4f901f69a8cc900f143fa67b05381a12e2f/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d41c4f901f69a8cc900f143fa67b05381a12e2f

commit 8d41c4f901f69a8cc900f143fa67b05381a12e2f
Author: jam <jam@chromium.org>
Date: Mon Jan 30 20:47:44 2017

Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2660643003
Cr-Commit-Position: refs/heads/master@{#447056}

[modify] https://crrev.com/8d41c4f901f69a8cc900f143fa67b05381a12e2f/chrome/browser/ui/ash/launcher/browser_status_monitor.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3d5801d55db75ed92b135170b561f2eab7761f3

commit a3d5801d55db75ed92b135170b561f2eab7761f3
Author: jam <jam@chromium.org>
Date: Thu Feb 02 00:00:41 2017

Convert print_dialog_cloud::SignInObserver to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2665303003
Cr-Commit-Position: refs/heads/master@{#447649}

[modify] https://crrev.com/a3d5801d55db75ed92b135170b561f2eab7761f3/chrome/browser/printing/print_dialog_cloud.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25b3265878e57ef40f5422716f3b4f6e840a846

commit f25b3265878e57ef40f5422716f3b4f6e840a846
Author: jam <jam@chromium.org>
Date: Thu Feb 02 00:11:17 2017

Remove dead code since PDFWebContentsHelper::ShowOpenInReaderPrompt isn't called anymore.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2672463003
Cr-Commit-Position: refs/heads/master@{#447651}

[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/app/generated_resources.grd
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/location_bar/location_bar.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.cc
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/browser/ui/views/location_bar/location_bar_view.h
[delete] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
[delete] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h
[delete] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/chrome/browser/ui/views/open_pdf_in_reader_bubble_view.cc
[delete] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/chrome/browser/ui/views/open_pdf_in_reader_bubble_view.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/components/pdf/browser/BUILD.gn
[delete] https://crrev.com/6cd1e0590f82ef11669abfbf00d846d759235460/components/pdf/browser/open_pdf_in_reader_prompt_client.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/components/pdf/browser/pdf_web_contents_helper.cc
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/components/pdf/browser/pdf_web_contents_helper.h
[modify] https://crrev.com/f25b3265878e57ef40f5422716f3b4f6e840a846/components/pdf/browser/pdf_web_contents_helper_client.h

Project Member

Comment 54 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9

commit f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9
Author: jam <jam@chromium.org>
Date: Thu Feb 02 01:04:37 2017

Convert extensions::TabHelper to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2668003004
Cr-Commit-Position: refs/heads/master@{#447666}

[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/content_predicate_evaluator.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker_unittest.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_is_bookmarked_condition_tracker_unittest.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/api/declarative_content/declarative_content_page_url_condition_tracker_unittest.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/tab_helper.cc
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/chrome/browser/extensions/tab_helper.h
[modify] https://crrev.com/f1c7f0cc75e1443cb6f5d728e61dc0fcd24626e9/extensions/browser/api/declarative_content/content_rules_registry.h

Project Member

Comment 57 by bugdroid1@chromium.org, Feb 3 2017

Project Member

Comment 58 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ca71cc52d03f571730ac6c108a49ab11b4ee22

commit b5ca71cc52d03f571730ac6c108a49ab11b4ee22
Author: jam <jam@chromium.org>
Date: Mon Feb 06 13:04:16 2017

Convert DelegationTracker::DelegatedForChild to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2676203002
Cr-Commit-Position: refs/heads/master@{#448237}

[modify] https://crrev.com/b5ca71cc52d03f571730ac6c108a49ab11b4ee22/chrome/browser/permissions/delegation_tracker.cc

Project Member

Comment 60 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae35030e907ce6986123b73f10323f1c3e9672ee

commit ae35030e907ce6986123b73f10323f1c3e9672ee
Author: jam <jam@chromium.org>
Date: Mon Feb 06 16:31:47 2017

Convert ExtensionMessagePort::FrameTracker to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2679573002
Cr-Commit-Position: refs/heads/master@{#448270}

[modify] https://crrev.com/ae35030e907ce6986123b73f10323f1c3e9672ee/chrome/browser/extensions/api/messaging/extension_message_port.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69876c1ca4337aeb395fd09cb1388b32a990737c

commit 69876c1ca4337aeb395fd09cb1388b32a990737c
Author: jam <jam@chromium.org>
Date: Mon Feb 06 16:38:00 2017

Convert BrowserTest.NoStopDuringTransferUntilCommit to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2674163002
Cr-Commit-Position: refs/heads/master@{#448271}

[modify] https://crrev.com/69876c1ca4337aeb395fd09cb1388b32a990737c/chrome/browser/ui/browser_browsertest.cc

Project Member

Comment 62 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c247781839fa869394c70ab84fa4ba77d7e07ab

commit 4c247781839fa869394c70ab84fa4ba77d7e07ab
Author: jam <jam@chromium.org>
Date: Mon Feb 06 17:34:10 2017

Convert MediaPermissionRequestLogger to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2676523002
Cr-Commit-Position: refs/heads/master@{#448284}

[modify] https://crrev.com/4c247781839fa869394c70ab84fa4ba77d7e07ab/chrome/browser/media/webrtc/media_stream_devices_controller.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb

commit b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb
Author: jam <jam@chromium.org>
Date: Tue Feb 07 00:07:46 2017

Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with client side redirects. This matches the old API, which is necessary to make the tests pass after this conversion.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2657323003
Cr-Commit-Position: refs/heads/master@{#448454}

[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/chrome/browser/history/history_tab_helper.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/chrome/browser/history/history_tab_helper.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/interstitial_page_navigator_impl.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigator.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/common/frame_messages.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/common/navigation_params.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/public/browser/navigation_handle.h
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb/content/test/test_render_frame_host.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4fa7b06432f4af1b6f5baacc107b10f8338673

commit 3b4fa7b06432f4af1b6f5baacc107b10f8338673
Author: jam <jam@chromium.org>
Date: Tue Feb 07 17:46:20 2017

Convert ContentSettingBubbleWebContentsObserverBridge to use the new navigation callbacks.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2684643002
Cr-Commit-Position: refs/heads/master@{#448660}

[modify] https://crrev.com/3b4fa7b06432f4af1b6f5baacc107b10f8338673/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Project Member

Comment 75 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c8679269a9b601815b4665fd95c84d9963c7c50

commit 7c8679269a9b601815b4665fd95c84d9963c7c50
Author: jam <jam@chromium.org>
Date: Wed Feb 08 00:05:54 2017

Remove unnecessary line in PasswordManagerBrowserTestBase.

This wasn't doing anything since I converted ManagePasswordsUIController to the new callback in r446997.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2679983003
Cr-Commit-Position: refs/heads/master@{#448806}

[modify] https://crrev.com/7c8679269a9b601815b4665fd95c84d9963c7c50/chrome/browser/password_manager/password_manager_test_base.cc

Comment 79 by jam@chromium.org, Feb 13 2017

Status: Fixed (was: Started)
Project Member

Comment 80 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9905150f10743251466b608024ca2081f070498

commit b9905150f10743251466b608024ca2081f070498
Author: mharanczyk <mharanczyk@opera.com>
Date: Thu Mar 02 10:41:10 2017

React to not committed render frame navigations in devtools.

Currently it was trying to handle only error pages or committed
navigations which lead to RenderFrameDevToolsAgentHost being stuck
in suspended state for navigations that did not commit (for example
downloads). This in turn caused webdriver to get stuck on further
interactions with such frames. This is regression caused by
https://codereview.chromium.org/2655413002.

BUG= 682002 

Review-Url: https://codereview.chromium.org/2720823004
Cr-Commit-Position: refs/heads/master@{#454229}

[modify] https://crrev.com/b9905150f10743251466b608024ca2081f070498/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b9905150f10743251466b608024ca2081f070498/content/browser/devtools/site_per_process_devtools_browsertest.cc

Components: Internals>Network>Service
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment