New issue
Advanced search Search tips

Issue 682001 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:5283


Sign in to add a comment

Email begin sent on upload

Project Member Reported by dsinclair@chromium.org, Jan 17 2017

Issue description

When we do a git cl upload there is an email being triggered. This creates spam change emails as they get sent out for things like Rebasing to master and then a second CL as we go through and reply to the comments.

Is there a way not have emails automatically sent on cl upload?
 
Project: chromium
Moved issue gerrit:5283 to now be  issue chromium:682001 .
Components: Infra>Codereview>Gerrit
Labels: Milestone-Fishfood Proj-Gerrit-Migration Pri-2
Owner: aga...@chromium.org
Status: Assigned (was: New)

Comment 3 by aga...@chromium.org, Jan 17 2017

What email is being sent to which address(es)? This may be a duplicate of  issue 680605 .
They're being sent to pdfium-reviews@. The previous bug was for the first upload. This behaviour is for subsequent pushes of the same CL which I don't think it was emailing about previously?

Comment 5 by aga...@chromium.org, Jan 18 2017

Aha, gotcha. I guess I still don't quite follow, though. These threads ([1], [2], [3], [4], [5]) don't contain any messages corresponding to later patchset uploads.

In particular, [1] contains the following messages:
1) Initial upload
2 & 3) Comment on PS2 (no notification of upload of PS2)
4) Comment on PS3 (no notification of upload of PS3)
5 & 6) Comment on PS4 (no notification of upload of PS4)
7) Change has landed

So I'm not sure which messages you're referring to that are sent upon upload and shouldn't be sent.

[1] https://groups.google.com/forum/#!topic/pdfium-reviews/qfJjQTK2rWg
[2] https://groups.google.com/forum/#!topic/pdfium-reviews/gMhY4HMScKk
[3] https://groups.google.com/forum/#!topic/pdfium-reviews/IKJ3_UgqAPY
[4] https://groups.google.com/forum/#!topic/pdfium-reviews/P0arLPBfXGw
[5] https://groups.google.com/forum/#!topic/pdfium-reviews/QjHbuomdDx8

Comment 7 by aga...@chromium.org, Jan 18 2017

Status: WontFix (was: Assigned)
Aha. That's on Gerrit, not git-cl, so would be a lot harder to change. You didn't upload patchset 3, you created it online by editing the commit description. That automatically triggers a message from within Gerrit itself.

I've filed a feature request (https://bugs.chromium.org/p/gerrit/issues/detail?id=5291) on the gerrit side for making this avoidable, but in the mean time I'm going to mark this WontFix. There are some features of Gerrit that people are going to have to adjust to.

Sign in to add a comment