New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681992 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 681990



Sign in to add a comment

Remove @unrestricted to all Network files in devtools

Project Member Reported by allada@chromium.org, Jan 17 2017

Issue description

We need to remove @unrestricted and get closure to stop complaining.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f08826decc8e8e5630a470cad33f0a967375b07

commit 3f08826decc8e8e5630a470cad33f0a967375b07
Author: allada <allada@chromium.org>
Date: Fri Jan 27 04:19:37 2017

[Devtools] Added typing to network in prep for removing unrestricted

This patch adds the needed types to classes in order to remove
@unrestricted from all network classes.

R=pfeldman,luoe
BUG= 681992 

Review-Url: https://codereview.chromium.org/2653363002
Cr-Commit-Position: refs/heads/master@{#446590}

[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
[modify] https://crrev.com/3f08826decc8e8e5630a470cad33f0a967375b07/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Comment 2 by allada@chromium.org, Jul 20 2017

Status: WontFix (was: Assigned)
Hopeless :-(
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2774a85ff79d1eed4da98c1a891ea5d29b9a9f9

commit f2774a85ff79d1eed4da98c1a891ea5d29b9a9f9
Author: Nathan Bruer <allada@chromium.org>
Date: Tue Aug 08 01:27:41 2017

[Devtools] Remove @unrestricted from NetworkLogView

Code health to remove @unrestricted from our classes.

R=caseq,dgozman,einbinder
BUG= 681992 

Change-Id: I64fb9e834d4a756ece11694c3b6529bb55526b88
Reviewed-on: https://chromium-review.googlesource.com/587345
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492492}
[modify] https://crrev.com/f2774a85ff79d1eed4da98c1a891ea5d29b9a9f9/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/f2774a85ff79d1eed4da98c1a891ea5d29b9a9f9/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Sign in to add a comment