New issue
Advanced search Search tips

Issue 681987 link

Starred by 1 user
Status: Verified
Owner:
tapted@chromium.org
Closed: Oct 2017
Cc:
karandeepb@chromium.org
js...@chromium.org
msw@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

"fi" ligature followed by punctuation creates a break in the selection highlight

Project Member Reported by reillyg@chromium.org, Jan 17 2017 
Chrome Version: 57.0.2970.0 (Official Build) dev (64-bit)
OS: 9150.0.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
(1) Open a new tab.
(2) Type "fe.fi.fo.fum" in the address bar.
(3) Select the text in the address bar.

What is the expected result?
Text selection highlight should be continuous.

What happens instead?
There is a break in the selection highlight between the "i" and the next period.

Comment 1 by reillyg@chromium.org, Jan 17 2017

Screenshot 2017-01-17 at 13.42.24.png
2.3 KB View Download

Comment 2 by pkasting@chromium.org, Jan 17 2017

Components: -UI>Browser>Omnibox -Internals>Views UI>Input>Text

Comment 3 by tbuck...@chromium.org, Feb 9 2017

Status: WontFix (was: Untriaged)
Seems like this is fixed, I can't repro on samus 57.0.2987.19 (Official Build) dev (64-bit)

Comment 4 by reillyg@chromium.org, Feb 10 2017

Status: Untriaged (was: WontFix)
Still reproducible for me on 57.0.2987.32 (Official Build) dev (64-bit).

Comment 5 by weifangsun@chromium.org, Feb 14 2017

Owner: jchin...@chromium.org
Status: Assigned (was: Untriaged)
<triage> I was able to reproduce this on M57 samus. jchinlee@, could you take a look?

Comment 6 by weifangsun@chromium.org, Feb 14 2017

Owner: js...@chromium.org
<triage> Sorry, I think I assigned to the wrong ldap initially. jshin@, let me know if you're able to take a look?

Comment 7 by js...@chromium.org, Feb 16 2017

Cc: msw@chromium.org js...@chromium.org
Components: -UI>Input>Text UI>Browser>Omnibox UI>GFX
Owner: ----
Status: Untriaged (was: Assigned)
msw@ : who'd be the best person to look at this issue? 

It appears that somehow advance-width calculation is off when there's a ligature. (a font - I believe it's Roboto - could be to blame, but not likely. I'll look into Roboto metrics, too).

Comment 8 by msw@chromium.org, Feb 16 2017

Cc: karandeepb@chromium.org pkasting@chromium.org
Labels: Needs-Bisect
I'm not sure who's working on text rendering issues at the moment, sorry.
CC'ing some folks that might know; let's get a bisect if this is a regression?

Comment 9 by karandeepb@chromium.org, Feb 16 2017 

This may have been one of my changes. Waiting for the bisect.

Comment 10 by tommycli@chromium.org, Jun 20 2017

Status: Available (was: Untriaged)
I was able to reproduce this on ChromeOS, so it's a real bug.

Awaiting bisect, but marking as Available.

Comment 11 by mpear...@chromium.org, Jun 23 2017

Labels: -Pri-2 Hotlist-Polish Pri-3

Comment 12 by tapted@chromium.org, Oct 16 2017

Owner: tapted@chromium.org
Status: Assigned (was: Available)
I may have fixed this in r508331, just in time for m63.

Comment 13 by tapted@chromium.org, Oct 26 2017

Status: Fixed (was: Assigned)
Confirmed fixed (checked: 63.0.3203.0 lumpy)

Comment 14 by reillyg@chromium.org, Oct 26 2017 

I can still reproduce this on my dev-channel samus on 63.0.3236.0.

Comment 15 by tapted@chromium.org, Oct 26 2017

Status: Assigned (was: Fixed)
ugh - why are all our CrOS devices out of date :p. My lumpy claimed it was "Canary", but 3203 is super old. (I guess this never reprod there anyway).

Even 3236 is old, and before branch. r508331 landed in 3239 - so.. we'll have to hold our breath a little bit longer :)

Comment 16 by reillyg@chromium.org, Oct 27 2017

Status: Verified (was: Assigned)
Confirmed fixed on 63.0.3239.20.
►

Sign in to add a comment