alemate@ - I thought we were not firing 'network-connected' correctly, but we are. The oobe code is explicitly only looking for a 'network-connected' event after a network is selected. Is that desired behavior? It feels like a bug.

 Issue 678735  has been merged into this issue.

As noted with  issue 678735 , we also need to clear the highlighting when a network is selected.

Working on part 2 while I wait for a response to the question in comment #2.

I don't agree with [If a network is already connected (i.e. Ethernet) the screen should automatically flow to the next screen (or be skipped entirely)]. This may be undesired network, so I think we need an explicit user action before continuing.

But yes, not displaying "Connecting..." while network is being connected to, is actually a bug. Thank you for taking over this.

Issue 682826 has been merged into this issue.

So, selecting a network does not necessarily make it the default network.

In practice the only network that would be automatically connected to is Ethernet. Selecting a wifi network would connect to it, but the device will still be using the Ethernet connection.

FYI - I think I saw LTE automatically connect on my device, but I'm not 100% sure.

If you have a valid SIM, LTE might also connect automatically, but we can (and should) only look for connected non mobile networks before proceeding. (Edge case, but good catch!).

The current UI has a 'continue' button on the screen that includes network select (as a dropdown), we could just add a 'continue' button but still show the screen, it's just a little odd imho having to select an already connected network when plugged into ethernet.

Hmmm... May be I was unclear.
I think that:
1) We should always show "Network Selection" window even if some networks are already connected.
2) Click on a network should make it default network once connected.

I am not sure (2) works like this now, but I don't think we should fix it right now.

So I think that the only change that should be done, is displaying "Connecting..." message after user clicked on a network, until it receives "Connected" status. (And at that point the UI should switch to EULA screen.)

I think that it is still worth displaying "Select Network" screen after crash, because crash may be induced by network configuration. So selecting a different network may help user to work-around the issue.

I used to think of a "click on a network" as "selecting it as a default network", i.e. a network that I am going to use for OOBE. So I think it is reasonable to wait for user selection.

(2) is not an option. Ethernet will always have priority over WiFi. (The solution is to unplug the Ethernet cable).

As for recovering from a crash, that's the same problem as accidentally selecting the wrong WiFi network (e.g. something behind a captive portal). We should always have a way to select or change the WiFi network. It looks like currently you can use the status area for this (at least on a Linux build).

Ultimately this should be an informed UX decision, but I don't know who the UX designer is for OOBE? +sgabriel@ who may know and should at least have some context here.

It's Elizabeth. +elizabethchiu

To be clear (since a lot of the comments above are kind of confusing):

If a user goes through OOBE on a device connected to Ethernet:
* The network screen will be shown with Ethernet connected.
* Clicking on a WiFi network will connect to that network, but will not make it the default network (Ethernet is always the default if it is plugged in). This will move the user past the network select screen.
* Clicking the Ethernet network will also move the user past the network select screen.

I think this is confusing; we should check for a connected Ethernet network and skip the network select screen.

This will make OOBE development a lot harder: in Linux builds Ethernet is connected by default ;)

So I still think we should never skip this screen completely. 

out/Release/chrome --shill-stub=ethernet=0

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4

commit 53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Jan 20 16:54:47 2017

CrOS WebUI: Show 'Connecting' in network list and blur selected item

This also fixes the connected and connecting text to match the status area UI.

BUG= 681982 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2640923004
Cr-Commit-Position: refs/heads/master@{#445078}

[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/ui/webui/resources/cr_elements/network/cr_network_list_item.js
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/ui/webui/resources/cr_elements/network/cr_network_select.js
[modify] https://crrev.com/53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4/ui/webui/resources/cr_elements/network/cr_onc_types.js

Proposal to skip the network select screen while connected to Ethernet has been moved to  issue 684006 

We should merge this to 57 if we plan to ship MD OOBE in 57.

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/693fec55b955d1b4b63c924a0ab8d4820740db99

commit 693fec55b955d1b4b63c924a0ab8d4820740db99
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 23 19:02:39 2017

CrOS WebUI: Show 'Connecting' in network list and blur selected item

This also fixes the connected and connecting text to match the status area UI.

BUG= 681982 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2640923004
Cr-Commit-Position: refs/heads/master@{#445078}
(cherry picked from commit 53571e573b51a31cc1ad5c1aeda71b9d7f0b57d4)

Review-Url: https://codereview.chromium.org/2648323003 .
Cr-Commit-Position: refs/branch-heads/2987@{#32}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/ui/webui/resources/cr_elements/network/cr_network_list_item.js
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/ui/webui/resources/cr_elements/network/cr_network_select.js
[modify] https://crrev.com/693fec55b955d1b4b63c924a0ab8d4820740db99/ui/webui/resources/cr_elements/network/cr_onc_types.js

 Issue 664620  has been merged into this issue.