New issue
Advanced search Search tips

Issue 681950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

audiolistener-automation-basic-expected.txt exists, but no test file.

Project Member Reported by rtoy@chromium.org, Jan 17 2017

Issue description

There's an audiolistener-automation-basic-expected.txt file but no corresponding audiolistener-automation-basic.html file to generate the expected results.

Find the test file and restore it or remove the expected results.

 

Comment 1 by rtoy@chromium.org, Jan 17 2017

I think this file should be removed.  It was originally created in https://codereview.chromium.org/1820403002 in patch 1 but was removed in patch 7. I think the tests were eventually moved to panner-automation-basic.html.

So, remove this file.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151d7ef2a6bb9d6106aa4f3cfc658b9916371ef1

commit 151d7ef2a6bb9d6106aa4f3cfc658b9916371ef1
Author: rtoy <rtoy@chromium.org>
Date: Thu Jan 19 17:41:46 2017

Remove unused audiolistener-automation-basic-expected.txt.

This file was added in patch 1 of
https://codereview.chromium.org/1820403002, but was removed in patch
7. I think all of the tests related to this were moved to
panner-automation-basic.html, so we don't need to recreate the
original test script.  We can remove this expected result.

BUG= 681950 
TEST=none

Review-Url: https://codereview.chromium.org/2633313003
Cr-Commit-Position: refs/heads/master@{#444776}

[delete] https://crrev.com/2aa8f82ca789e98607dca43178a093b9d2b7ffb4/third_party/WebKit/LayoutTests/webaudio/AudioListener/audiolistener-automation-basic-expected.txt

Comment 3 by rtoy@chromium.org, Jan 25 2017

Status: Fixed (was: Started)

Sign in to add a comment