New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681936 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

(STRING)==(type_) in ast-value-factory.h

Project Member Reported by ClusterFuzz, Jan 17 2017

Issue description

Owner: rmcilroy@chromium.org
Status: Assigned (was: Untriaged)
rmcilroy @ as per recent change assigned this to you ,could you please look into this and please feel free to re assigned back if needed ,thanks in advance 
Cc: rmcilroy@chromium.org
Owner: marja@chromium.org
I don't think any of my changes could have caused this. Marja, would you mind taking a look? Feel free to assign back if it's something I can help with.

Comment 3 by marja@chromium.org, Jan 18 2017

Investigating; this reproes with plain d8.

In debug mode, there's this failure:

mutant7218_regress-670808.js

#
# Fatal error in ../../src/ast/ast.h, line 1212
# Check failed: IsPropertyName().
#

==== C stack trace ===============================

And in release mode, it's the one in the report. That failing DCHECK is guarding it:

  const AstRawString* AsRawPropertyName() {
    DCHECK(IsPropertyName());
    return value_->AsString();
  }

However, the bug report afaics doesn't contain the V8 bisect info so I'll need to bisect this manually.

Comment 4 by marja@chromium.org, Jan 18 2017

Cc: titzer@chromium.org aseemgarg@chromium.org marja@chromium.org
Owner: bradnelson@chromium.org
The culprit is this commit:

commit f6929084821d4f021b2c2768c9856472ffa42623
Author: bradnelson <bradnelson@chromium.org>
Date:   Thu Jan 12 18:26:07 2017 -0800

    [wasm][asm.js] Enable --validate-asm by default.
    
    This directs all asm.js traffic via the Wasm backend.
    Make asm.js console output less noisy.
    
    R=titzer@chromium.org,aseemgarg@chromium.org
    BUG= v8:4203 
    
    Review-Url: https://codereview.chromium.org/2624813002
    Cr-Original-Original-Commit-Position: refs/heads/master@{#42194}
    Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad
    Review-Url: https://codereview.chromium.org/2624813002
    Cr-Original-Commit-Position: refs/heads/master@{#42244}
    Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a35178046
    Review-Url: https://codereview.chromium.org/2624813002
    Cr-Commit-Position: refs/heads/master@{#42300}

Labels: Hotlist-Asm
Project Member

Comment 7 by ClusterFuzz, Jan 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6661486564081664 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment