Issue 681929 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	tbansal@chromium.org
Closed:	Jan 2017
Components:	Internals>Network Internals>Network>NetworkQuality
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug
M-58

Blocking:
issue 513681

NQE should update signal strength periodically

Project Member Reported by tbansal@chromium.org, Jan 17 2017

Issue description

Currently, Network Quality Estimator (NQE) updates signal strength on main frame requests. This is broken since main-frame is not really a net-layer concept. To fix this, NQE should update signal strength periodically (every N requests or every N seconds)

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190e126297503e8c5da6bd72390af82dc757a897

commit 190e126297503e8c5da6bd72390af82dc757a897
Author: tbansal <tbansal@chromium.org>
Date: Thu Jan 26 15:07:06 2017

NetworkQualityEstimator: Update signal strength estimate periodically

Currently, the signal strength is updated when a main frame request
is received. That approach does not work for net embedders that do
not have a main frame concept (e.g., via cronet). This CL changes NQE
to update the signal strength periodically without relying on the main frame requests.

BUG= 681929 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2650573002
Cr-Commit-Position: refs/heads/master@{#446329}

[modify] https://crrev.com/190e126297503e8c5da6bd72390af82dc757a897/net/nqe/network_quality_estimator.cc