use sort -V for version in run_suite |
|||
Issue descriptionrun_suite build list should be ordered by version https://screenshot.googleplex.com/1wVLQFgLehc.png should show 9000.60.0 9000.59.0 9000.56.0 9000.6.0 should not be sandwich in the middle. (In shell you can use sort -V to sort by version, python should have something similar)
,
May 10 2017
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3102fd49b27f975966a4dadef540b2e5c6de4926 commit 3102fd49b27f975966a4dadef540b2e5c6de4926 Author: Keith Haddow <haddowk@chromium.org> Date: Thu May 11 03:58:09 2017 [moblab] Sort the build numbers correctly when generating build list. Build numbers were being sorted by standard cmp - change to a custom comparison that gets the order correct. BUG= chromium:681915 TEST=unit tests and local moblab testing Change-Id: I3d1ae480420aa8ff9b1c96bec161106f0b0aca4b Reviewed-on: https://chromium-review.googlesource.com/502048 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> [modify] https://crrev.com/3102fd49b27f975966a4dadef540b2e5c6de4926/frontend/afe/moblab_rpc_interface_unittest.py [modify] https://crrev.com/3102fd49b27f975966a4dadef540b2e5c6de4926/frontend/afe/moblab_rpc_interface.py
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/73b1709539074ec7b8635908b05031da82d1ef56 commit 73b1709539074ec7b8635908b05031da82d1ef56 Author: Keith Haddow <haddowk@chromium.org> Date: Thu May 11 23:26:31 2017 [moblab] Sort the build numbers correctly when generating build list. Build numbers were being sorted by standard cmp - change to a custom comparison that gets the order correct. BUG= chromium:681915 TEST=unit tests and local moblab testing Change-Id: I3d1ae480420aa8ff9b1c96bec161106f0b0aca4b Reviewed-on: https://chromium-review.googlesource.com/502048 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Michael Tang <ntang@chromium.org> (cherry picked from commit 3102fd49b27f975966a4dadef540b2e5c6de4926) Reviewed-on: https://chromium-review.googlesource.com/503479 Reviewed-by: Jinsong Mu <jinsong@google.com> Commit-Queue: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/73b1709539074ec7b8635908b05031da82d1ef56/frontend/afe/moblab_rpc_interface_unittest.py [modify] https://crrev.com/73b1709539074ec7b8635908b05031da82d1ef56/frontend/afe/moblab_rpc_interface.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by ntang@google.com
, Mar 6 2017