New issue
Advanced search Search tips

Issue 681913 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Autotest "recurring run" feature appears unused

Reported by jrbarnette@chromium.org, Jan 17 2017

Issue description

The Chrome OS Autotest sources include RPC functions, UI
features, and other code references to the ability to create
a "recurring run".  This feature is rarely, if ever used,
may not work, and likely should be considered dead code.

The starting point for code removal should be these RPC
calls:
    frontend/client/src/autotest/afe/RecurringTable.java
    frontend/client/src/autotest/afe/RecurringView.java

That code contains the only references to these RPC functions:
    get_recurring
    get_num_recurring
    delete_recurring_runs
    create_recurring_run

 

Comment 1 by xixuan@chromium.org, Jan 29 2017

Owner: xixuan@chromium.org

Comment 2 by xixuan@chromium.org, Jan 31 2017

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4de4e74d1eeedf605e272530c780f2632a62181c

commit 4de4e74d1eeedf605e272530c780f2632a62181c
Author: xixuan <xixuan@chromium.org>
Date: Fri Feb 03 13:15:08 2017

autotest: Remove backend dead codes related to recurring jobs.

This CL removes all backend dead codes related to recurring jobs.

BUG= chromium:681913 
TEST=Run local AFE, run a repair job for a DUT.
Run unittest. Run 'python models.test'.

Change-Id: I95d4ba9bdf47741cf82ca05808985a181e3ce467
Reviewed-on: https://chromium-review.googlesource.com/434838
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/4de4e74d1eeedf605e272530c780f2632a62181c/frontend/afe/models.py
[modify] https://crrev.com/4de4e74d1eeedf605e272530c780f2632a62181c/scheduler/monitor_db.py
[modify] https://crrev.com/4de4e74d1eeedf605e272530c780f2632a62181c/frontend/afe/rpc_interface.py

Labels: cros-infra-fixedit-q117
Status: Fixed (was: Started)
another CL is https://chromium-review.googlesource.com/c/434109/. Mark this bug as closed.

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment