New issue
Advanced search Search tips

Issue 681906 link

Starred by 2 users
Status: Archived
Owner:
ayatane@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Autotest "atomic groups" in Chrome OS not meaningful

Reported by jrbarnette@chromium.org, Jan 17 2017 
The Autotest scheduler include a (vestigial) feature for
something called "atomic groups".  This feature is unused
in the Chrome OS fork of Autotest, and should be removed.

The starting point for removal is the code in 'cli/atomicgroup.py',
and these implementing RPC calls:
    add_atomic_group
    modify_atomic_group
    delete_atomic_group
    atomic_group_add_labels
    atomic_group_remove_labels
    get_atomic_groups

Additionally, there's code under "scheduler" that consults
the database, and there are presumably Django models that can
be removed.

Comment 1 by jrbarnette@chromium.org, Jan 18 2017 

In addition to the scheduler changes, atomic groups can be parameters
to create_job, so the support in that function should be deleted.

Comment 2 by jrbarnette@chromium.org, Jan 23 2017 

Here's a more comprehensive listing of the changes needed:
 1) In the GWT (Java) UI code, there's a checkbox labeled
    "Exclude atomic groups".  That code can be deleted.
 2) Deleting the code in 1) means that in the get_hosts()
    RPC, the "exclude_atomic_group_hosts" parameter is dead, and
    should be deleted down the call change.
 3) The "atomic_group_name" parameter to the create_job() RPC
    call is dead, and should be deleted down the call chain.
 4) The stuff in cli/atomicgroup.py can be deleted.  This could
    make other code dead in consequence
 5) The various "atomic_group" RPC calls can be deleted down the
    call chain.  Most of them are dead now; the remainder will be
    bad dead by deleting the CLI code.

Comment 3 by jrbarnette@chromium.org, Jan 23 2017 

... more ...
 6) Code under 'scheduler' that mentions atomic groups will be made
    dead after the other code is deleted, and...
 7) When all that's done, various database tables (and probably some
    columns) will become unused.

Comment 4 by ayatane@chromium.org, Jan 30 2017

Owner: ayatane@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cb6d625183148f286f070dc9325a16886a0ea798

commit cb6d625183148f286f070dc9325a16886a0ea798
Author: Allen Li <ayatane@chromium.org>
Date: Thu Feb 02 04:27:51 2017

[autotest] [atomic] Remove why_isnt_my_job_running

This script is very old and appears to exist for atomic group jobs.

BUG= chromium:681906 
TEST=Run unittest suite

Change-Id: Iebe7af75f00d7063caa0f1a4c8d7107d88b81444
Reviewed-on: https://chromium-review.googlesource.com/435574
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[delete] https://crrev.com/465f02dfaabc33080487087cd6bbbea3fdbd7ec7/cli/contrib/common.py
[delete] https://crrev.com/465f02dfaabc33080487087cd6bbbea3fdbd7ec7/cli/contrib/why_isnt_my_job_running.py

Comment 7 by jrbarnette@chromium.org, Feb 2 2017 

 Issue 628734  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/20a5d8b3989979f76acbc4138dce4770354bb694

commit 20a5d8b3989979f76acbc4138dce4770354bb694
Author: Allen Li <ayatane@chromium.org>
Date: Fri Feb 03 07:31:07 2017

[autotest] [atomic] Remove atomic groups from server/

BUG= chromium:681906 
TEST=Run unittest suite

Change-Id: I9beea2528785fb07913ed69638b36d5a5538703b
Reviewed-on: https://chromium-review.googlesource.com/435564
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/20a5d8b3989979f76acbc4138dce4770354bb694/server/sequence.py
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8389f8befd2a23188462ac6c1bd1fb5e9bc44c4e

commit 8389f8befd2a23188462ac6c1bd1fb5e9bc44c4e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Mar 17 03:30:47 2017

[autotest] Remove compare_dut_perf

Remove old script that hasnt been touched in years.

BUG= chromium:681906 
TEST=Run unittest suite

Change-Id: I04e2d3db2eb785e0d3be131a6a301aa7c3a419cb
Reviewed-on: https://chromium-review.googlesource.com/435563
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[delete] https://crrev.com/a62f92d1a9102b14750b466d255f7b4276a0983e/contrib/compare_dut_perf.py
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0f261debdbba7664ef7b0eacbac0e7daba89eebd

commit 0f261debdbba7664ef7b0eacbac0e7daba89eebd
Author: Allen Li <ayatane@chromium.org>
Date: Fri Mar 17 22:58:56 2017

[autotest] [atomic] Remove atomic groups from scheduler

BUG= chromium:681906 
TEST=Run unittest suite

Change-Id: If9c144aae8d2a8df567a5a03b02bc3fec5d14c0d
Reviewed-on: https://chromium-review.googlesource.com/435565
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/scheduler_models_unittest.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/utils/unittest_suite.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/scheduler_models.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/monitor_db_functional_test.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/monitor_db.py
[add] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/only_if_needed_unittests.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/monitor_db_unittest.py
[modify] https://crrev.com/0f261debdbba7664ef7b0eacbac0e7daba89eebd/scheduler/monitor_db_cleanup.py
[delete] https://crrev.com/d81f9d9a1f484f78ed7a0d901381afd966535d86/scheduler/atomic_group_unittests.py
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/204eac11dbaf4b5659ebefdb50a536c821e9bb3e

commit 204eac11dbaf4b5659ebefdb50a536c821e9bb3e
Author: Allen Li <ayatane@chromium.org>
Date: Fri Mar 17 22:58:57 2017

[autotest] [atomic] Remove atomic groups RPC

BUG= chromium:681906 
TEST=Run unittest suite

Change-Id: I7b46a4390000a3ed6500b2db0f893b7dfaa04ce6
Reviewed-on: https://chromium-review.googlesource.com/435566
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/scheduler/scheduler_models_unittest.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/rpc_utils.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/doctests/001_rpc_test.txt
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/frontend_test_utils.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/apache/conf/django-directives
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/rpc_interface_unittest.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/admin.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/models.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/cli/host_unittest.py
[modify] https://crrev.com/204eac11dbaf4b5659ebefdb50a536c821e9bb3e/frontend/afe/rpc_interface.py

Comment 13 by ayatane@chromium.org, Jun 20 2017

Status: Fixed (was: Available)

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment