New issue
Advanced search Search tips

Issue 681900 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cache storage size mismatch DCHECK being hit constantly

Project Member Reported by roc...@chromium.org, Jan 17 2017

Issue description

In development builds, if I use a profile more than once, i.e. run chromium with the same user-data-dir for two consecutive runs, I consistently hit a browser crash on startup, with this DCHECK:

[9161:9198:0117/102656.894881:ERROR:cache_storage_cache.cc(1394)] Cache size/index mismatch
[9161:9198:0117/102656.894936:FATAL:cache_storage_cache.cc(1395)] Check failed: cache_size_ == cache_size (188770 vs. 187992)
#0 0x7f51decda95e base::debug::StackTrace::StackTrace()
#1 0x7f51decfee5b logging::LogMessage::~LogMessage()
#2 0x7f51dc4c88fc content::CacheStorageCache::InitGotCacheSize()
#3 0x7f51dc4cf31b _ZN4base8internal13FunctorTraitsIMN7content17CacheStorageCacheEFvRKNS_8CallbackIFvvELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEENS2_17CacheStorageErrorEiEvE6InvokeIRKNS_7WeakPtrIS3_EEJSA_RKSB_iEEEvSD_OT_DpOT0_
#4 0x7f51de7f6f46 disk_cache::SimpleBackendImpl::IndexReadyForSizeCalculation()
#5 0x7f51de76a569 _ZN4base8internal13FunctorTraitsIMN3net24ElementsUploadDataStreamEFvRK13scoped_refptrINS2_17DrainableIOBufferEEiEvE6InvokeIRKNS_7WeakPtrIS3_EEJS8_iEEEvSA_OT_DpOT0_
#6 0x7f51de8031a0 _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFviELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJN3net5ErrorEEEEFvvEE3RunEPNS0_13BindStateBaseE
#7 0x7f51decdb52e base::debug::TaskAnnotator::RunTask()
#8 0x7f51ded0c5ad base::MessageLoop::RunTask()
#9 0x7f51ded0cf46 base::MessageLoop::DoWork()
#10 0x7f51ded10059 base::MessagePumpLibevent::Run()
#11 0x7f51ded0c305 base::MessageLoop::RunHandler()
#12 0x7f51ded4065c base::RunLoop::Run()
#13 0x7f51ded7c8ec base::Thread::Run()
#14 0x7f51dc4a6995 content::BrowserThreadImpl::IOThreadRun()
#15 0x7f51dc4a6b43 content::BrowserThreadImpl::Run()
#16 0x7f51ded7cde8 base::Thread::ThreadMain()
#17 0x7f51ded7478c base::(anonymous namespace)::ThreadFunc()
#18 0x7f51dee51184 start_thread
#19 0x7f51d560537d clone

Assigning to cmumford@ for triage based on comments in cache_storage_cache.cc.
 
I'm going to disable the DCHECK.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9964f41926c6d9d18a9fbf338d4f8acb3d1825a2

commit 9964f41926c6d9d18a9fbf338d4f8acb3d1825a2
Author: cmumford <cmumford@chromium.org>
Date: Tue Jan 17 20:26:40 2017

[CacheStorage] Disabled cached size DCHECK.

The cache size, saved in the index file, was getting out-of-sync with
the actual cache size. A speculative fix was landed in crrev.com/2613183003
but even if this fixed the problem, this DCHECK would still fail
with no obvious resolution. Disabling this DCHECK - at least temporarily.

BUG= 681900 

Review-Url: https://codereview.chromium.org/2635313002
Cr-Commit-Position: refs/heads/master@{#444122}

[modify] https://crrev.com/9964f41926c6d9d18a9fbf338d4f8acb3d1825a2/content/browser/cache_storage/cache_storage_cache.cc

Status: Fixed (was: Assigned)
Note that it's generally a bad thing to DCHECK based on something external, outside the control of the immediate code.

Sign in to add a comment