CQ+2 and CQ button aren't available |
|||||||||
Issue descriptionFor some reasons, I don't have a 'Submit' button on my CLs even when I've got an LGTM from an appropriate committer. Examples of CLs where I haven't seen that button: https://chromium-review.googlesource.com/c/427842/ https://chromium-review.googlesource.com/c/427841/ https://chromium-review.googlesource.com/c/426821/
,
Jan 13 2017
,
Jan 17 2017
,
Jan 17 2017
,
Jan 17 2017
Can you please upload another CL for us to reproduce this on? All of the CLs you initially linked have been merged, so we can't verify which buttons do/don't show up.
,
Jan 17 2017
When you've uploaded and gotten LGTM on a whitespace CL, please reassign back to me.
,
Jan 18 2017
Sure! Uploaded https://chromium-review.googlesource.com/c/429830/, waiting for a LGTM there.
,
Jan 18 2017
Done: https://chromium-review.googlesource.com/c/429830/ Assigning this back to you Aaron.
,
Feb 21 2017
Rising up the priority as this bug blocks me from doing my work and fixing build issues (e.g. issue 693624 and CL referenced at it). Consequently, I have to disturb other folks by asking them to click 'Submit' button for me :(
,
Feb 21 2017
Another test CL created together with tandrii@: https://chromium-review.googlesource.com/c/445226/
,
Feb 21 2017
This is how it looks from my account https://screenshot.googleplex.com/j8CShevErgV
,
Feb 21 2017
Aaron, I think permissions for showing CQ button are not quite right in build repo. Since I've deployed CQ for contributors, we can relax CQ+2 to every registered user. PTAL https://chromium-review.googlesource.com/#/c/445646/
,
Feb 22 2017
Sorry I dropped the ball on this. Thanks for updating the CQ permissions now that we have the cq for contributors, tandrii! This should be fixed. Please mark verified if it is, or repoen if not.
,
Feb 22 2017
I still do not see a CQ button on https://chromium-review.googlesource.com/c/445226/ Should I upload another CL to verify, or this one is expected to work as well?
,
Feb 22 2017
Sorry,Max, we've forgot to land my CL before marking as fixed. I did land my CL just now. Can you please check now?
,
Feb 22 2017
Unbelievable! It's a blue rectangle with "Submit to CQ" text, I see it!!! Thanks a lot :) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mmoroz@chromium.org
, Jan 13 2017