New issue
Advanced search Search tips

Issue 681894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Previous locations:
gerrit:5263


Sign in to add a comment

CQ+2 and CQ button aren't available

Project Member Reported by mmoroz@chromium.org, Jan 13 2017

Issue description

For some reasons, I don't have a 'Submit' button on my CLs even when I've got an LGTM from an appropriate committer.

Examples of CLs where I haven't seen that button:

https://chromium-review.googlesource.com/c/427842/

https://chromium-review.googlesource.com/c/427841/

https://chromium-review.googlesource.com/c/426821/
 

Comment 1 by mmoroz@chromium.org, Jan 13 2017

I also cannot edit my report here. Could anyone please change the summary to be "Submit button isn't available"?

Comment 2 by ekempin@google.com, Jan 13 2017

Summary: Submit button isn't available (was: Submit button doesn't available)
Project: chromium
Moved issue gerrit:5263 to now be  issue chromium:681894 .
Cc: tandrii@chromium.org
Components: Infra>Codereview>Gerrit Infra>Git>Admin
Labels: Milestone-Dogfood Proj-Gerrit-Migration Pri-2
Owner: aga...@chromium.org
Status: Assigned (was: New)

Comment 5 by aga...@chromium.org, Jan 17 2017

Owner: mmoroz@chromium.org
Can you please upload another CL for us to reproduce this on? All of the CLs you initially linked have been merged, so we can't verify which buttons do/don't show up.

Comment 6 by aga...@chromium.org, Jan 17 2017

Cc: aga...@chromium.org
When you've uploaded and gotten LGTM on a whitespace CL, please reassign back to me.

Comment 7 by mmoroz@chromium.org, Jan 18 2017

Sure! Uploaded https://chromium-review.googlesource.com/c/429830/, waiting for a LGTM there.

Comment 8 by mmoroz@chromium.org, Jan 18 2017

Cc: -aga...@chromium.org
Owner: aga...@chromium.org
Done: https://chromium-review.googlesource.com/c/429830/

Assigning this back to you Aaron.

Comment 9 by mmoroz@chromium.org, Feb 21 2017

Cc: infe...@chromium.org
Labels: -Pri-2 Pri-1 Type-Bug
Rising up the priority as this bug blocks me from doing my work and fixing build issues (e.g.  issue 693624  and CL referenced at it). Consequently, I have to disturb other folks by asking them to click 'Submit' button for me :(

Another test CL created together with tandrii@: https://chromium-review.googlesource.com/c/445226/
This is how it looks from my account https://screenshot.googleplex.com/j8CShevErgV
Summary: CQ+2 and CQ button aren't available (was: Submit button isn't available)
Aaron, I think permissions for showing CQ button are not quite right in build repo. Since I've deployed CQ for contributors, we can relax CQ+2 to every registered user. PTAL https://chromium-review.googlesource.com/#/c/445646/
Status: Fixed (was: Assigned)
Sorry I dropped the ball on this. Thanks for updating the CQ permissions now that we have the cq for contributors, tandrii!

This should be fixed. Please mark verified if it is, or repoen if not.
I still do not see a CQ button on https://chromium-review.googlesource.com/c/445226/

Should I upload another CL to verify, or this one is expected to work as well?
Sorry,Max, we've forgot to land my CL before marking as fixed. I did land my CL just now.

Can you please check now?
Unbelievable! It's a blue rectangle with "Submit to CQ" text, I see it!!! Thanks a lot :)

Sign in to add a comment