New issue
Advanced search Search tips

Issue 681864 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[Missing Tests]: dd CHECK to EnumerateDevices call in PepperDeviceManager

Project Member Reported by durga.behera@chromium.org, Jan 17 2017

Issue description

guidou@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit: https://codereview.chromium.org/2519273003

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=666715

Thanks,
 

Comment 1 by guidou@chromium.org, Jan 18 2017

Status: WontFix (was: Assigned)
The referenced commit is not a bug fix. It just adds a CHECK in a renderer callsite in order to make future crashes provide more information in case the crash originated from that site. There is no new functionality to test in that case.

It is not clear that issue 666715 was an actual bug since it looked like the renderer was being killed for sending illegal arguments to the renderer.
The code in content/renderer is written to never send illegal arguments in the way they were being sent in the crash.

Marking as WontFix since there is nothing to test in the referenced commit.
Please reopen if you think there is more action to be taken.

Sign in to add a comment