Files app: Error is output in console when right click a file. |
||||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Open Files app (2) In Downloads, right click any file. What is the expected result? No error happens. What happens instead? Error is output as seen in the screenshot. "TypeError: Cannot read property 'width' of undefined", which comes from FileTransferController.preloadThumbnailImage_. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 17 2017
,
Jan 18 2017
,
Jan 18 2017
I confirmed it happens when clicking on or dragging a non-image file which is not yet previously selected, and it's introduced by a recent change. I'll revert the affecting part of the change once by: https://codereview.chromium.org/2641743002/
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/461ae5544464cdc9d3429311f553568f95da2b2a commit 461ae5544464cdc9d3429311f553568f95da2b2a Author: yamaguchi <yamaguchi@chromium.org> Date: Wed Jan 18 09:25:52 2017 Change the drag thumbnail rendering back to IMAGE mode to fix a regression. Here is the change that caused crbug.com/681796 . This changelist partially reverts its change that affected drag thumbnail rendering. https://codereview.chromium.org/2630283002/ When an item is rendered in CANVAS mode, some metadata field are not filled unlike IMAGE mode. It causes unexpected execution path and outputs an error when clicking on a non-image file whose thumbnail is not yet cached. BUG= 681796 , 680420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2641743002 Cr-Commit-Position: refs/heads/master@{#444311} [modify] https://crrev.com/461ae5544464cdc9d3429311f553568f95da2b2a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
,
Jan 18 2017
,
Mar 4 2017
,
Mar 28 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, Jan 17 2017Owner: yamaguchi@chromium.org