New issue
Advanced search Search tips

Issue 681784 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[Bluetooth] Update the layout of Bluetooth device list in MD Settings.

Project Member Reported by fukino@chromium.org, Jan 17 2017

Issue description

Chrome Version: ToT
OS: Chrome OS

Mock: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png%3Fz=width

Following changes are needed to implement the latest mock.
* Device type icons should be shown on the device list.
* Connection status ("Connected", "Not connected") should be shown as labels instead of the current check icon.
* Clicking a device on the paring dialog should not start paring immediately. Instead, the device should be selected and "CONNECT" button should be shown on the dialog footer.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd83b32c7de902ee531d61a03762fbde0bc5ac8

commit dcd83b32c7de902ee531d61a03762fbde0bc5ac8
Author: fukino <fukino@chromium.org>
Date: Wed Jan 18 01:24:13 2017

MD Settings: Add Bluetooth device type icons in device lists.

The mapping from device types to icons is consistent with the Bluetooth list in
the system menu.
Newly added device icons are copyed from
https://github.com/PolymerElements/iron-icons/blob/master/hardware-icons.html
with the same id.

BUG= 681784 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2637053002
Cr-Commit-Position: refs/heads/master@{#444225}

[modify] https://crrev.com/dcd83b32c7de902ee531d61a03762fbde0bc5ac8/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/dcd83b32c7de902ee531d61a03762fbde0bc5ac8/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js
[modify] https://crrev.com/dcd83b32c7de902ee531d61a03762fbde0bc5ac8/chrome/browser/resources/settings/icons.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab6ef0674b570234efbdce00f18814a3dbbcff4

commit 0ab6ef0674b570234efbdce00f18814a3dbbcff4
Author: fukino <fukino@chromium.org>
Date: Fri Jan 20 01:43:13 2017

MD Settings: Bluetooth: Use labels instead of icons to show connection status.

For devices which are not paird nor connecting, either "Connected" or
"Not connected" should be shown below the device name in device list.
This also adds separator between devices as specified in the mock.

BUG= 681784 
TEST=manually compared with the mock
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2643653003
Cr-Commit-Position: refs/heads/master@{#444931}

[modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js
[modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Labels: -Pri-1 Pri-2
Is this fixed?

Comment 4 by fukino@chromium.org, Jan 25 2017

Not yet.
"Connect" button in the device paring dialog has not been implemented.

As you mention in the comment in https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png%3Fz=width, I'm not sure if we should add the button either.
Let me confirm it.
Status: Fixed (was: Started)
Making as Fixed.

The remaining item (the third item in the issue description) was modified in the latest mock and integrated to  issue 673946 .
Components: OS>Systems>Bluetooth
Labels: bluetooth
Status: Verified (was: Fixed)
closing this issue. will raise new issues for any changes needed for the Bluetooth menu in md-settings

Sign in to add a comment