[Bluetooth] Update the layout of Bluetooth device list in MD Settings. |
||||||
Issue descriptionChrome Version: ToT OS: Chrome OS Mock: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png%3Fz=width Following changes are needed to implement the latest mock. * Device type icons should be shown on the device list. * Connection status ("Connected", "Not connected") should be shown as labels instead of the current check icon. * Clicking a device on the paring dialog should not start paring immediately. Instead, the device should be selected and "CONNECT" button should be shown on the dialog footer.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ab6ef0674b570234efbdce00f18814a3dbbcff4 commit 0ab6ef0674b570234efbdce00f18814a3dbbcff4 Author: fukino <fukino@chromium.org> Date: Fri Jan 20 01:43:13 2017 MD Settings: Bluetooth: Use labels instead of icons to show connection status. For devices which are not paird nor connecting, either "Connected" or "Not connected" should be shown below the device name in device list. This also adds separator between devices as specified in the mock. BUG= 681784 TEST=manually compared with the mock CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2643653003 Cr-Commit-Position: refs/heads/master@{#444931} [modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/app/settings_strings.grdp [modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html [modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js [modify] https://crrev.com/0ab6ef0674b570234efbdce00f18814a3dbbcff4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jan 24 2017
Is this fixed?
,
Jan 25 2017
Not yet. "Connect" button in the device paring dialog has not been implemented. As you mention in the comment in https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW_Bluetooth.png%3Fz=width, I'm not sure if we should add the button either. Let me confirm it.
,
Feb 6 2017
Making as Fixed. The remaining item (the third item in the issue description) was modified in the latest mock and integrated to issue 673946 .
,
Feb 10 2017
,
Feb 22 2017
,
Apr 6 2017
closing this issue. will raise new issues for any changes needed for the Bluetooth menu in md-settings |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 18 2017