New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681783 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Touch-Bar


Sign in to add a comment

[Missing Tests]: [Mac] Opt browser window controller out of being a touch bar provider

Project Member Reported by tkonch...@chromium.org, Jan 17 2017

Issue description

rsesek@, Automated tests for the below commit have been missing and would be really great to add them ASAP since these issues are high priority regressions.

Commit:  https://codereview.chromium.org/2550463002

Ref. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=667274

Thanks,
 
 

Comment 1 by treib@chromium.org, Jan 17 2017

Owner: rsesek@chromium.org

Comment 2 by rsesek@chromium.org, Jan 19 2017

Owner: lgrey@chromium.org
I'm not the author of this CL. Re-assigning (though I think a test here is not practical or useful).
Cc: shrike@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Leonard is OOTO until mid Feb. We need another owner. 

Comment 4 by tapted@chromium.org, Jan 25 2017

Status: WontFix (was: Untriaged)
[mac triage]  Issue 667274  isn't a regression, so the statement in the description is false.

I also agree that tests are not practical.

Comment 5 by shrike@chromium.org, Jan 25 2017

Labels: -M-55 M-58
Owner: sdy@chromium.org
Status: Assigned (was: WontFix)
Hmm, it seems like a test might not be practical, but I'm not sure it's clearly the case. We want to make sure that the browser window controller is not a touch bar provider - it's possible that you need a touch bar Mac to test for this, but given that I can call up the touch bar simulator via Xcode (i.e. no rebooting or anything) I suspect that all of the touch bar stack is in place, just dormant waiting for some piece of a framework to call it.

(I don't know if tapted@ has a different reason for thinking this test is impractical.)

So the first thing to try is writing an app that checks to see if a window controller responds to a touch bar method, and running that on a non-touch bar 10.12 Mac. I'm guessing that it will respond to the method. Then add the code to opt out of the two protocols listed in the cl, and confirm that the window controller no longer responds to the method. Assuming that works, the test would be a browser test that fails if the window controller responds to the touch bar method.

Comment 6 by sdy@chromium.org, Feb 23 2017

Labels: -Pri-1 Pri-2
Owner: lgrey@chromium.org
Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment