New issue
Advanced search Search tips

Issue 681780 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Only allow http and https item in reading list

Project Member Reported by olivierrobin@chromium.org, Jan 17 2017

Issue description

Do not show "Read Later" context menu for other URLs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d4cf487be9accac21945f3ec095f5d7df49dc0

commit 51d4cf487be9accac21945f3ec095f5d7df49dc0
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Jan 17 13:32:35 2017

Reading List: Show "Read Later" only on HTTP or HTTPS scheme.

Current test allow data scheme which should not be allowed in Reading List.

BUG= 681780 

Review-Url: https://codereview.chromium.org/2637983002
Cr-Commit-Position: refs/heads/master@{#444039}

[modify] https://crrev.com/51d4cf487be9accac21945f3ec095f5d7df49dc0/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 58.0.2991.0 dev, iPhone 6S iOS 10.1, iPhone 6 iOS 9.3.5 iPad mini 4 10.1
Steps:
1. installing firefox-ios
2. in firefox, visit http://browsingtest.appspot.com/external_url_links.html
3. long press on "Calendar URL"
4. Share link
5. Chrome

Observed:
Error dialog is shown for for urls that are not HTTP or HTTPS.
Note: in Chrome, the context menu for this link is only "Copy".

Sign in to add a comment