New issue
Advanced search Search tips

Issue 681760 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Jan 2017
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 517298



Sign in to add a comment

SpellCheckRequester should invoke requests in sequence order

Project Member Reported by xiaoche...@chromium.org, Jan 17 2017 
Currently, SpellCheckRequester does not invoke requests in sequence order. A request with a larger sequence number can be invoked earlier than a request with a smaller sequence. In other words, request invocation order is not the same as creation order.

This is not really a bug as all requests gets invoked eventually. However, it makes testing difficult, which blocks the development of idle time spell checker.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b

commit f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Jan 18 05:33:11 2017

Ensure same invocation order as creation order for SpellCheckRequests

This patch makes SpellCheckRequester maintain its request queue in
ascending order of sequence, so that request invocation order is always
the same as creation order.

It eases the testing of idle time spell checker.

BUG= 681760 

Review-Url: https://codereview.chromium.org/2635173002
Cr-Commit-Position: refs/heads/master@{#444283}

[modify] https://crrev.com/f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-queue.html
[modify] https://crrev.com/f740ee973fc6b34c8788c3e8fb5b6f63e9a3633b/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Comment 2 by xiaoche...@chromium.org, Jan 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment