New issue
Advanced search Search tips

Issue 681757 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add ChromeOS autotest for ARC camera HAL

Project Member Reported by wuchengli@chromium.org, Jan 17 2017

Issue description

We need a new ChromeOS autotest for ARC camera HAL (arc-camera3-test).

 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ede271fc760ec8f175c045036507004f9dc9f628

commit ede271fc760ec8f175c045036507004f9dc9f628
Author: Daniel Hung-yu Wu <hywu@chromium.org>
Date: Fri Jan 20 06:55:17 2017

autotest: add ebuild for camera HALv3 autotest

This autotest is a wrapper for camera HALv3 test. It will run
on machines that are known to support ARC++.

BUG= chromium:681757 
TEST='emerge-kevin chromeos-base/autotest-tests'
     'test_that kevin camera_HAL3'

Change-Id: Ieb93ee6efb10a0757bc7b95be13c7820ff98826a
CQ-DEPEND=CL:430594
Reviewed-on: https://chromium-review.googlesource.com/430532
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>
Commit-Queue: Wu-cheng Li <wuchengli@chromium.org>
Tested-by: Wu-cheng Li <wuchengli@chromium.org>

[add] https://crrev.com/ede271fc760ec8f175c045036507004f9dc9f628/chromeos-base/autotest-deps-camera-hal3/autotest-deps-camera-hal3-9999.ebuild
[modify] https://crrev.com/ede271fc760ec8f175c045036507004f9dc9f628/chromeos-base/autotest-tests/autotest-tests-9999.ebuild

Comment 4 by cmt...@chromium.org, Jan 26 2017

I was just running a completely different test using the chromiumos-sdk builder, and the builder died in the uprev phase complaining that this particular package does not contain a 9999 ebuild file:

10:14:39: ERROR: Missing 9999 ebuild in /b/cbuild/external_master/src/third_party/chromiumos-overlay/chromeos-base/autotest-deps-camera-hal3

Here's the link for the entire build:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chromiumos-sdk/builds/2090
Several toolchain builders failed today because of compiler warnings in building arc-camera3-test.

arc-camera3-test-0.0.1-r8: camera3_test/camera3_frame_test.cc:49:29: error: non-constant-expression cannot be narrowed from type 'size_type' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
arc-camera3-test-0.0.1-r8:       .num_output_buffers = output_buffers.size(),
arc-camera3-test-0.0.1-r8:                             ^~~~~~~~~~~~~~~~~~~~~
arc-camera3-test-0.0.1-r8: camera3_test/camera3_frame_test.cc:49:29: note: insert an explicit cast to silence this issue
arc-camera3-test-0.0.1-r8:       .num_output_buffers = output_buffers.size(),
arc-camera3-test-0.0.1-r8:                             ^~~~~~~~~~~~~~~~~~~~~
arc-camera3-test-0.0.1-r8:                             static_cast<uint32_t>( )
arc-camera3-test-0.0.1-r8: 1 error generated.
arc-camera3-test-0.0.1-r8: make[1]: *** [common.mk:934: camera3_test/camera3_frame_test.pie.o] Error 1
arc-camera3-test-0.0.1-r8: make[1]: *** Waiting for unfinished jobs....
arc-camera3-test-0.0.1-r8: camera3_test/camera3_frame_test.cc:49:29: error: non-constant-expression cannot be narrowed from type 'size_type' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
arc-camera3-test-0.0.1-r8:       .num_output_buffers = output_buffers.size(),
arc-camera3-test-0.0.1-r8:                             ^~~~~~~~~~~~~~~~~~~~~
arc-camera3-test-0.0.1-r8: camera3_test/camera3_frame_test.cc:49:29: note: insert an explicit cast to silence this issue
arc-camera3-test-0.0.1-r8:       .num_output_buffers = output_buffers.size(),
arc-camera3-test-0.0.1-r8:                             ^~~~~~~~~~~~~~~~~~~~~
arc-camera3-test-0.0.1-r8:                             static_cast<uint32_t>( )
arc-camera3-test-0.0.1-r8: 1 error generated.
arc-camera3-test-0.0.1-r8: make[1]: *** [common.mk:934: camera3_test/camera3_frame_test.pic.o] Error 1

https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-gcc-toolchain/builds/137/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio

https://uberchromegw.corp.google.com/i/chromeos/builders/amd64-llvm-toolchain/builds/137/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio


Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/03a9a93e05c78584a0e21a39613118140230a954

commit 03a9a93e05c78584a0e21a39613118140230a954
Author: Daniel Hung-yu Wu <hywu@chromium.org>
Date: Fri Mar 03 02:34:09 2017

autotest: add ebuild for camera HALv3 autotest

This autotest is a wrapper for camera HALv3 test. It will run
on machines that are known to support ARC++.

BUG= chromium:681757 
TEST='emerge-kevin chromeos-base/autotest-tests'
     'test_that kevin camera_HAL3'
CQ-DEPEND=CL:439069,CL:448343

Change-Id: I1c08026f7dd52af5a47135f25e3d8235c7157cc7
Reviewed-on: https://chromium-review.googlesource.com/439844
Commit-Ready: Hung-yu Wu <hywu@chromium.org>
Tested-by: Hung-yu Wu <hywu@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[add] https://crrev.com/03a9a93e05c78584a0e21a39613118140230a954/chromeos-base/autotest-deps-camera-hal3/autotest-deps-camera-hal3-9999.ebuild
[modify] https://crrev.com/03a9a93e05c78584a0e21a39613118140230a954/media-libs/arc-camera3-test/arc-camera3-test-9999.ebuild
[modify] https://crrev.com/03a9a93e05c78584a0e21a39613118140230a954/chromeos-base/autotest-tests/autotest-tests-9999.ebuild

Status: Fixed (was: Assigned)
I see the test in wmatrix. Great job!
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fdcb71f31a23609dccd3c858156926d5c7e71046

commit fdcb71f31a23609dccd3c858156926d5c7e71046
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Aug 10 00:19:41 2017

autotest-tests: enable HAL3 tests for arc-camera3 systems only

Turning this on for all systems doesn't make sense.

BUG= chromium:681757 
TEST=precq passes

Change-Id: Ibd9a86ca084bade3c4b2667374da67c774d0202a
Reviewed-on: https://chromium-review.googlesource.com/598110
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[modify] https://crrev.com/fdcb71f31a23609dccd3c858156926d5c7e71046/chromeos-base/autotest-tests/autotest-tests-9999.ebuild

Sign in to add a comment