New issue
Advanced search Search tips

Issue 681736 link

Starred by 3 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jan 2017
Cc:
jeffcarp@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

update-w3c-deps doesn't work due to no html5lib

Project Member Reported by tkent@chromium.org, Jan 17 2017 
Chrome Version: ToT
OS: Ubuntu 14.04 LTS, OSX 10.11

What steps will reproduce the problem?
(1) Run ./third_party/WebKit/Tools/Scripts/update-w3c-deps wpt

What is the expected result?
Import tests successfully.

What happens instead?

Noting the current Chromium commit.
Cloning https://chromium.googlesource.com/external/w3c/web-platform-tests.git into /usr/local/google/home/tkent/chrome/src/third_party/WebKit/wpt.
Checking out 82173128ef6f536e5faaafc29eecc521380f81ae
Noting the revision we are importing.
Cleaning out tests from LayoutTests/imported/wpt.
Importing the tests.
Deleting any orphaned baselines.
Generating MANIFEST.json
# ret> 1
# err> Traceback (most recent call last):
# err>   File "/usr/local/google/home/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest", line 5, in <module>
# err>     from tools.manifest import update
# err>   File "/usr/local/google/home/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/__init__.py", line 3, in <module>
# err>     from . import sourcefile
# err>   File "/usr/local/google/home/tkent/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/sourcefile.py", line 11, in <module>
# err>     import html5lib
# err> ImportError: No module named html5lib


Please use labels and text to provide additional information.

Comment 1 by tkent@chromium.org, Jan 17 2017

Labels: OS-Linux OS-Mac

Comment 2 by qyears...@chromium.org, Jan 17 2017

Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Oh, looks like I didn't notice this because I had html5lib installed locally from another source, and apparently w3c-test-autoroller bot also has html5lib installed from another source, I think.

Comment 3 by qyears...@chromium.org, Jan 19 2017

Cc: -qyears...@chromium.org foolip@chromium.org jeffcarp@chromium.org
Components: -Blink>Infra Blink>Infra>Predictability
Labels: -OS-Linux -Pri-3 -OS-Mac Pri-2
Status: Started (was: Assigned)
Proposed CL: https://codereview.chromium.org/2635033005

Comment 4 by pwnall@chromium.org, Jan 24 2017 

Is the CL (and therefore this bug) blocked on a security review?

FWIW, before the WPT contribution process exits dogfood, either the CL should be landed, or documentation should be updated with a workaround. If going down the latter route, it may be worth noting that I needed to install pip on my Ubuntu workstation in order to get html5lib.

Thank you very much for looking into this!

Comment 5 by qyears...@chromium.org, Jan 24 2017 

It was blocked on security review approval, but now after an email to the security review mailing lists, it looks like that CL is OK; now trying to commit :-)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fc58f0e3b68581b5832176bfd922bc28ecb7b54

commit 1fc58f0e3b68581b5832176bfd922bc28ecb7b54
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Jan 24 19:04:34 2017

Add html5lib to the list of modules in webkitpy/thirdparty/wpt/wpt/tools.

The purpose of this copy of html5lib is to make the
web-platform-tests `manifest` script work properly - I don't
think I would want to make any other code depend on a library in
//third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/.

The reason why I wanted to check in the `manifest` script and all
dependencies here is just so that we can use a pinned version of
the manifest command, so that upstream changes in that script can't
unexpectedly break us (like they did a couple weeks ago).

BUG= 681736 

Review-Url: https://codereview.chromium.org/2635033005
Cr-Commit-Position: refs/heads/master@{#445771}

[modify] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/LICENSE
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/README.rst
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/constants.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/_base.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/alphabeticalattributes.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/inject_meta_charset.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/lint.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/optionaltags.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/sanitizer.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/filters/whitespace.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/html5parser.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/ihatexml.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/inputstream.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/sanitizer.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/serializer/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/serializer/htmlserializer.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/tokenizer.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treeadapters/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treeadapters/sax.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treebuilders/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treebuilders/_base.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treebuilders/dom.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treebuilders/etree.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treebuilders/etree_lxml.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/_base.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/dom.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/etree.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/genshistream.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/lxmletree.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/treewalkers/pulldom.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/trie/__init__.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/trie/_base.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/trie/datrie.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/trie/py.py
[add] https://crrev.com/1fc58f0e3b68581b5832176bfd922bc28ecb7b54/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/html5lib/html5lib/utils.py

Comment 7 by pwnall@chromium.org, Jan 24 2017 

I synced past this CL and I can run the manifest tool without a local html5lib install. I think this issue can be closed. Thank you very much!

Comment 8 by qyears...@chromium.org, Jan 24 2017

Status: Fixed (was: Started)
Alright, thanks for confirming!

Comment 9 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 10 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment