Graphyte: Change the DUT / Instrument plugin API |
||
Issue description1. Change TxConfig and RxConfig as optional implementation. TxConfig or RxConfig is aimed to configure the device setting before transmitting or receiving. But in practice we just implemented the configuration in the TxStart or RxMeasure in most case. 2. Remove test_type and rf_type argument in each API. These two arguments are for function delegation. After delegating to the API they are useless. 3. Add the rx_number_packets and rx_number_bits in the Bluetooth Rx API. There are 3 kinds of packet type in Bluetooth testing: BDR, EDR, and LE. We measure packet error rate in LE, and measure bit error rate in BDR and EDR. Therefore we need the number of transmitted packets in LE, otherwise the number of transmitted bits. Add these two arguments in each Bluetooth Rx API with default value "None".
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/graphyte/+/70947d878ab885e4944d72dd7b9feda1fa5d82a7 commit 70947d878ab885e4944d72dd7b9feda1fa5d82a7 Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Jan 17 03:25:02 2017 Add the rx_number_packets and rx_number_bits in Bluetooth Rx API. There are 3 kinds of packet type in Bluetooth testing: BDR, EDR, and LE. We measure packet error rate in LE, and measure bit error rate in BDR and EDR. Therefore we need the number of transmitted packets in LE, otherwise the number of transmitted bits. Add these two arguments in each Bluetooth Rx API with default value "None". BUG= chromium:681734 TEST=make test Change-Id: I3fd5abec604f6e4f9f6956846f14133403713e05 Reviewed-on: https://chromium-review.googlesource.com/428478 Commit-Ready: Chih-Yu Huang <akahuang@chromium.org> Tested-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Joel Kitching <kitching@chromium.org> [modify] https://crrev.com/70947d878ab885e4944d72dd7b9feda1fa5d82a7/graphyte/dut/__init__.py [modify] https://crrev.com/70947d878ab885e4944d72dd7b9feda1fa5d82a7/graphyte/inst/__init__.py
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/graphyte/+/68ab9f05b8fea271f2b29ab0116d53a8d26ca823 commit 68ab9f05b8fea271f2b29ab0116d53a8d26ca823 Author: Chih-Yu Huang <akahuang@google.com> Date: Mon Dec 19 04:18:26 2016 Remove test_type and rf_type argument in each API. These two arguments are for function delegation. After delegating to the API, they are useless. Also fixed the style of the docstring. BUG= chromium:681734 TEST=make test Change-Id: I762b7d1b334663e602e448604f27e4ef6b62312f Reviewed-on: https://chromium-review.googlesource.com/428479 Commit-Ready: Chih-Yu Huang <akahuang@chromium.org> Tested-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Joel Kitching <kitching@chromium.org> [add] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/device.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/testplan.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/dut/sample/dummy_dut.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/utils.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/graphyte.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/port_config.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/inst/__init__.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/data_parser.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/dut/__init__.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/result_writer.py [modify] https://crrev.com/68ab9f05b8fea271f2b29ab0116d53a8d26ca823/graphyte/inst/sample/dummy_inst.py
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/graphyte/+/d99e1e86ab38819c880d48dfea1445d2fe02aee1 commit d99e1e86ab38819c880d48dfea1445d2fe02aee1 Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Jan 17 03:36:12 2017 Change TxConfig and RxConfig as optional implementation. `TxConfig` or `RxConfig` is aimed to configure the device setting before transmitting or receiving. But in practice we just implemented the configuration in the TxStart or RxMeasure in most case. We will consider to remove these APIs later. BUG= chromium:681734 TEST=make test Change-Id: Ib2173e8db08272fc69a77b333828b0185fdcdf19 Reviewed-on: https://chromium-review.googlesource.com/428480 Commit-Ready: Chih-Yu Huang <akahuang@chromium.org> Tested-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Joel Kitching <kitching@chromium.org> [modify] https://crrev.com/d99e1e86ab38819c880d48dfea1445d2fe02aee1/graphyte/dut/__init__.py [modify] https://crrev.com/d99e1e86ab38819c880d48dfea1445d2fe02aee1/graphyte/inst/__init__.py
,
Mar 6 2017
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/graphyte/+/c63233a40044e4aa5fb9a57a85d25df8ec3cd447 commit c63233a40044e4aa5fb9a57a85d25df8ec3cd447 Author: Chih-Yu Huang <akahuang@google.com> Date: Tue Mar 21 12:02:07 2017 Add `PowerMetercontrollerBase` class. The RF controller of the power meter should be able to measure all kinds of RF type. Therefore we set the dafault RF type "ALL" that accepts every RF type. BUG= chromium:681734 TEST=make test Change-Id: I20578bf285fb2b21968c477ff910c7a0e3e91968 Reviewed-on: https://chromium-review.googlesource.com/453580 Commit-Ready: Chih-Yu Huang <akahuang@chromium.org> Tested-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Joel Kitching <kitching@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/c63233a40044e4aa5fb9a57a85d25df8ec3cd447/graphyte/inst/anritsu/ml2437a.py [modify] https://crrev.com/c63233a40044e4aa5fb9a57a85d25df8ec3cd447/graphyte/inst/keysight/n1914a.py [modify] https://crrev.com/c63233a40044e4aa5fb9a57a85d25df8ec3cd447/graphyte/device.py [modify] https://crrev.com/c63233a40044e4aa5fb9a57a85d25df8ec3cd447/graphyte/inst/__init__.py |
||
►
Sign in to add a comment |
||
Comment 1 by akahuang@chromium.org
, Jan 17 2017