New issue
Advanced search Search tips

Issue 681718 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Long Tasks API: remove clamping

Project Member Reported by panicker@chromium.org, Jan 17 2017

Issue description

Currently we "floor" to clamp resolution to milliseconds. Instead consider rounding, if applicable.
 
Cc: panicker@chromium.org
Owner: npm@chromium.org
Status: WontFix (was: Assigned)
This turned out to be more complicated than expected.

Marking WontFix.

Comment 3 by npm@chromium.org, Jul 26 2017

Cc: tdres...@chromium.org
From upstream discussion it seems that there is an agreement on dropping the clamping altogether?
Cc: igrigo...@chromium.org
Status: Assigned (was: WontFix)
Summary: Long Tasks API: remove clamping (was: Long Tasks API: round vs floor)
Yup, SGTM.

Upstream discussion here:
https://github.com/w3c/longtasks/issues/29

Is there a spec change required to go along with this?
Yes, I believe Shubhie is taking care of the spec bits?

Comment 6 by panicker@google.com, Jul 26 2017

Spec update in tiny, Nicolas you can just delete this line in the spec:
"also timing info provided is clamped to 1ms resolution" in Security section.

Comment 7 by npm@chromium.org, Jul 26 2017

I've submitted pull requests upstream.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23aed6337b63fc16197f2176e75c837655320a48

commit 23aed6337b63fc16197f2176e75c837655320a48
Author: Nicolas Pena <npm@chromium.org>
Date: Wed Aug 02 00:22:40 2017

Long tasks: do not clamp times

This CL drops clamping for long tasks to improve accuracy.
Discussion at https://github.com/w3c/longtasks/issues/29

Bug:  chromium:681718 
Change-Id: If6df344f0203f7b6347f54ffa49be8d6689b7d71
Reviewed-on: https://chromium-review.googlesource.com/587590
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491166}
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-attributes.html
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-externalscript.html
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-attributes.html
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-externalscript.html
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/LayoutTests/http/tests/performance-timing/longtask/longtask-raf.html
[modify] https://crrev.com/23aed6337b63fc16197f2176e75c837655320a48/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Comment 9 by npm@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment