New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 681709 link

Starred by 3 users
Status: Fixed
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Feb 2017
Cc:
dominickn@chromium.org
█ meredithl@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Migrate CONTENT_SETTINGS_TYPE_PROMPT_NO_DECISION_COUNT to a more general name

Project Member Reported by dominickn@chromium.org, Jan 16 2017 
The PermissionDecisionAutoBlocker currently uses a content setting called CONTENT_SETTINGS_TYPE_PROMPT_NO_DECISION_COUNT. However, its responsibilities are becoming more broad than just counting no decisions, so we should migrate the data to a new, better named content setting to avoid confusion.

Comment 1 by dominickn@chromium.org, Jan 24 2017

Cc: -raymes@chromium.org dominickn@chromium.org
Owner: raymes@chromium.org
Over to raymes :)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9c50e16b337d650bd09aec84be30ca1e76d40ab

commit d9c50e16b337d650bd09aec84be30ca1e76d40ab
Author: raymes <raymes@chromium.org>
Date: Wed Feb 01 20:03:35 2017

Migrate content setting PROMPT_NO_DECISION_COUNT to PERMISSION_AUTOBLOCKER_DATA

The PROMPT_NO_DECISION_COUNT name is no longer accurate so we migrate
the data to a new content setting. The old content setting can be
removed after M60. A test is added to ensure the migration works
properly.

BUG= 681709 

Review-Url: https://codereview.chromium.org/2651123002
Cr-Commit-Position: refs/heads/master@{#447585}

[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/d9c50e16b337d650bd09aec84be30ca1e76d40ab/components/content_settings/core/common/content_settings_types.h

Comment 3 by raymes@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment