New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681695 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 681160



Sign in to add a comment

Enable shared-memory implementation for Android

Project Member Reported by asvitk...@chromium.org, Jan 16 2017

Issue description

Enable shared-memory implementation for Android.

This is a follow-up of crbug.com/663918 which added support for all the other platforms.
 
Blocking: 681160
Labels: M-58
Will wait until branch point to land.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d5915aabda618649aea2495a8b08da938cb269

commit f8d5915aabda618649aea2495a8b08da938cb269
Author: asvitkine <asvitkine@chromium.org>
Date: Mon Jan 23 20:14:09 2017

Enable field trial shared memory segment on Android.

This is the last platform (not counting iOS) that didn't have this support,
which was added last fall for the other platforms. The other platforms
were enabled under crbug.com/663918

Turns out, it just works.

I tested this on a local build and verified that things are working correctly
via an induced chrome://crash which had all the field trials and the expected
command line flags.

This CL mostly cleans up the ifdefs and moves one function so that its order
matches the header file. Also reduces the !NACL ifdefs by defining an anon
wrapper around TerminateBecauseOutOfMemory() which doesn't exist for
NACL.

BUG= 681695 

Review-Url: https://codereview.chromium.org/2633203002
Cr-Commit-Position: refs/heads/master@{#445457}

[modify] https://crrev.com/f8d5915aabda618649aea2495a8b08da938cb269/base/metrics/field_trial.cc
[modify] https://crrev.com/f8d5915aabda618649aea2495a8b08da938cb269/base/metrics/field_trial.h

Status: Fixed (was: Started)

Sign in to add a comment