New issue
Advanced search Search tips

Issue 681693 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Gerrit topic titles can be improved

Project Member Reported by npm@chromium.org, Jan 16 2017

Issue description

What steps will reproduce the problem?
I get daily abridged summaries of pdfium CL's (for those where pdfium-reviews@googlegroups.com is CC'd).

For CL's at https://codereview.chromium.org, the title I get is "<CL_Title> (issue <CL_Number> by <CL_author>)". Example:
Remove unused CJS_Object::ExitInstance() method (issue 2628843003 by tsepez@chromium.org).

For CL's at https://pdfium-review.googlesource.com, the title I get is "Change in pdfium[master]: <CL_Title>". Example:
Change in pdfium[master]: Start CSS parser unit tests

It would be nice to have the unneeded "Change in pdfium[master]:" removed, and the CL_author included.

The topics and titles are from the Google Group pdfium-reviews.

 

Comment 1 by aga...@chromium.org, Jan 18 2017

Owner: aga...@chromium.org
Status: Started (was: Untriaged)
This is configurable on a per-site basis. chromium and chrome-internal already have a custom email subject that looks like

<CL_TITLE> [repo/name : branch]

I've created a CL to give pdfium the same format: cl/144882435

Comment 2 by aga...@chromium.org, Jan 18 2017

(The change author is not included in the subject because the change author is on the from: line.)
Labels: Pri-2

Comment 4 by aga...@chromium.org, Mar 27 2017

Status: Fixed (was: Started)

Sign in to add a comment