New issue
Advanced search Search tips

Issue 681656 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.5% regression in thread_times.tough_scrolling_cases at 443322:443445

Project Member Reported by nzolghadr@chromium.org, Jan 16 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=681656

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg4KLWtQoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 17 2017

Cc: khushals...@chromium.org
Owner: khushals...@chromium.org

=== Auto-CCing suspected CL author khushalsagar@chromium.org ===

Hi khushalsagar@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : khushalsagar
  Commit : 5889b84078b874e7682a4634b1fce6eedcac67fb
  Date   : Thu Jan 12 19:37:33 2017
  Subject: cc: Don't create SyncedPropety instances on the main thread.

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame
  Change       : 1.77% | 25.0034026776 -> 25.4456720768

Revision             Result                   N
chromium@443321      25.0034 +- 0.16655       6      good
chromium@443323      25.1113 +- 0.216924      6      good
chromium@443324      25.1827 +- 0.349328      9      good
chromium@443325      25.4231 +- 0.292059      6      bad       <--
chromium@443329      25.5278 +- 0.25585       6      bad
chromium@443337      25.3386 +- 0.270887      6      bad
chromium@443352      25.498 +- 0.390743       6      bad
chromium@443383      25.2067 +- 0.293969      9      bad
chromium@443445      25.4457 +- 0.335435      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.tough_scrolling_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990282770243580992

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5908018836799488


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: -khushals...@chromium.org ajuma@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look. Might be the refcount churn from copying all SyncedProperty instances on activation. https://cs.chromium.org/chromium/src/cc/trees/property_tree.cc?l=1408

Comment 6 by ajuma@chromium.org, Jan 18 2017

The 700 KB memory regression that's also associated with this bug seems unlikely to be from the SyncedProperty CL, so I've started a bisect for that.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jan 18 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/load_tools/load_tools_maps

Revision             Result                   N
chromium@443443      82380898 +- 3256934      21      good
chromium@443516      82287860 +- 3644969      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.maps system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990173893670924816

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6455387588395008


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 18 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame

Revision             Result                   N
chromium@443321      25.1936 +- 0.788082      21      good
chromium@443445      25.1936 +- 0.6167        21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.tough_scrolling_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990171829856870144

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5260761762365440


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
Looks like the initial bisect was incorrect. Marking this as WontFix.
Labels: Performance-Responsiveness

Sign in to add a comment