Issue 681616 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ pihsun@chromium.org Last visit > 30 days ago
Closed:	Feb 2017
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-59 VerifyIn-60 VerifyIn-61

factory: goofy state.py: File not found: /usr/local/factory/py_pkg/cros/factory/goofy/static/deps.js

Project Member Reported by hungte@chromium.org, Jan 16 2017

Issue description

Logs from ToT toolkit seems reporting missing JS file deps.js.
This should not happen since our goofy.js should be already compiled by closure, and
dep.js should be only required for debugging version that was not compiled.

Probably goofy.js has done something wrong and caused missing some classes in dependency?

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1d9d27bb05633020b1b21528fac025fcadf39ab8

commit 1d9d27bb05633020b1b21528fac025fcadf39ab8
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Feb 07 12:59:49 2017

goofy: set CLOSURE_NO_DEPS to true in index.html

We're using script mode for goofy.js output, not compiled mode, closure
library would try to include a deps.js for extra custom dependencies.

Since we don't have this file, we can set CLOSURE_NO_DEPS to true to
skip this step, and prevent a warning in factory.log.

BUG= chromium:681616 
TEST=make test
TEST=manually, install new toolkit on device, and check that there's no
     'File not found' error in /var/log/factory.log.

Change-Id: I3727dec06026c5ec614f25a9a0a972d8bbc97b14
Reviewed-on: https://chromium-review.googlesource.com/438946
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/1d9d27bb05633020b1b21528fac025fcadf39ab8/py/goofy/static/index.html