New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 681593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Bug



Sign in to add a comment

[Autofill] Credit Card signin-promo has no top/bottom padding.

Project Member Reported by ma...@chromium.org, Jan 16 2017

Issue description

See the screenshot. Need top/bottom padding on the credit card promo.
 
padding.png
27.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fe3d39e93d6f7b4ba011074fc322fecb713d3f6

commit 3fe3d39e93d6f7b4ba011074fc322fecb713d3f6
Author: mathp <mathp@chromium.org>
Date: Tue Jan 17 17:49:57 2017

[Autofill] Increase padding for multiline labels in dropdown

For multiline labels, the dropdown wrapper view height was set to
WRAP_CONTENT instead of a fixed height. However this leaves no padding on
the text view.

BUG= 681593 
TEST=manual

Review-Url: https://codereview.chromium.org/2630383002
Cr-Commit-Position: refs/heads/master@{#444086}

[modify] https://crrev.com/3fe3d39e93d6f7b4ba011074fc322fecb713d3f6/ui/android/java/src/org/chromium/ui/DropdownAdapter.java

Comment 2 by ma...@chromium.org, Jan 18 2017

Labels: Merge-Request-56
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 18 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by hdodda@chromium.org, Jan 19 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested on Ubuntu 14.04 using chrome M57 #57.0.2986.0 and couldn't find credit card sign-in promo in card autofill details.

Steps tried to verify :

1. Added credit card details in chrome://settings://auto-fill settings.
2. Enabled the flag "enable-features=AutofillCreditCardSigninPromo" and logged into the amazon.com
3. Added an item to cart , proceeded till payment and selected the autofilled card details in creedit card field and observed that no sign-in promo is displayed in card field.

Attached screencast for reference.

@mathp-- Could you please check the attached screencast and confirm us if we had followed the correct steps and if any other steps to verify the fix ,please provide us.

Thanks!
681593.ogv
2.8 MB View Download

Comment 5 by ma...@chromium.org, Jan 19 2017

The credit card promo will only show if there are no saved credit cards.
Labels: -Merge-Review-56 Merge-Approved-56
Merge approved for M56 branch 2924.

Comment 7 by ma...@chromium.org, Jan 20 2017

Labels: -Hotlist-Merge-Review -Merge-Approved-56
Unfortunately it's not mergeable (too much has changed in this code to do this safely). Will stay in M57 only.

Tester in #c4, this is an Android fix only.

Sign in to add a comment