New issue
Advanced search Search tips

Issue 681562 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Sysroot][Wayland] Missing 'libxkbcommon0' and 'libxkbcommon-dev' packages

Project Member Reported by toniki...@chromium.org, Jan 16 2017

Issue description

In order to add Wayland keyboard support, we need libxkbcommon0 and libxkbcommon-dev packages added to the sysroots.

Similar thing was done by thomasanderson@ in https://codereview.chromium.org/2415933004 .


 
Cc: dpranke@chromium.org
More details, both packages (libxkbcommon0 and libxkbcommon-dev) are present in jessie sysroot (used for arm64 builds), but not on wheezy (used for amd64 builds).


Cc: -thomasanderson@chromium.org
Owner: thomasanderson@chromium.org
Status: Started (was: Untriaged)
Owner: toniki...@chromium.org
Status: Available (was: Started)
Unfortunately the libxkbcommon0 and libxkbcommon-dev packages aren't available in Wheezy.  However, the packages are already in the jessie sysroot.

tonikitoo@: What you can do is modify build/config/sysroot.gni to add a condition that checks for ozone wayland builds and uses the jessie sysroot instead.

You will need to do something like in this CL: https://codereview.chromium.org/2361223002/diff/80001/build/config/sysroot.gni
Thanks Tom.

jessie sysroot is ARM64 (//src/build/linux/debian_jessie_arm64-sysroot/), not amd64. Is this the jessie sysroot you meant to be used?
Ok, I now understood your comment in comment #3. I had a trailing jessie-arm64 sysroot deployed locally, which confused me.

So from looking at build/config/sysroot.gni, chromeos/desktop builds require 'precise' sysroot downloaded.
The idea here would be adding a new check where if chromeos/desktop/ozone/wayland builds, we use the jessie sysroot instead.

Alternatively, https://codereview.chromium.org/2361223002/ would likely fix the problem at the bottom level. Will put a CL together anyways. 
Cc: thomasanderson@chromium.org
Sorry, I un-cc'ed myself from this on accident, so was unable to reply.  I added some comments on your CL.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/121fdaf4f383c1618d86f14fb4a210e52769e467

commit 121fdaf4f383c1618d86f14fb4a210e52769e467
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Jan 18 21:01:23 2017

Add libxkbcommon packages to precise sysroot

This CL:
* Adds libxkbcommon0 and libxkbcommon-dev packages to the precise
  sysroot.
* Modifies sysroot-creator.sh to support multiple repos.  (eg. main,
  universe, multiverse).
* Rolls sysroots

BUG= 681562 
R=dpranke@chromium.org
CC=tonikitoo@chromium.org

Review-Url: https://codereview.chromium.org/2645693002
Cr-Commit-Position: refs/heads/master@{#444475}

[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.amd64
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.arm
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.arm64
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.i386
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.mipsel
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.precise.amd64
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.trusty.arm
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroot-creator-precise.sh
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroot-creator.sh
[modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroots.json

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2d68eae813e2234e28798e81c423df7946fbe01

commit c2d68eae813e2234e28798e81c423df7946fbe01
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Jan 24 01:50:49 2017

Download Jessie sysroot on ozone builds

BUG= 681562 
R=dpranke@chromium.org
CC=tonikitoo@igalia.com

Review-Url: https://codereview.chromium.org/2645733006
Cr-Commit-Position: refs/heads/master@{#445588}

[modify] https://crrev.com/c2d68eae813e2234e28798e81c423df7946fbe01/build/linux/sysroot_scripts/install-sysroot.py

Status: Fixed (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f836955cb7ca30cffc60a95bc337a5b6fa092c

commit 58f836955cb7ca30cffc60a95bc337a5b6fa092c
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Jan 25 19:24:06 2017

Build ozone/linux_os with jessie sysroot when use_ozone=true

This is needed because Debian/wheezy (currently used) does not support
libxkbcommon0/libxkbcommon-dev packages, needed for keyboard support on
Ozone/Wayland.

BUG= 681562 

Review-Url: https://codereview.chromium.org/2645523003
Cr-Commit-Position: refs/heads/master@{#446081}

[modify] https://crrev.com/58f836955cb7ca30cffc60a95bc337a5b6fa092c/build/config/sysroot.gni

Sign in to add a comment