[Sysroot][Wayland] Missing 'libxkbcommon0' and 'libxkbcommon-dev' packages |
|||||
Issue descriptionIn order to add Wayland keyboard support, we need libxkbcommon0 and libxkbcommon-dev packages added to the sysroots. Similar thing was done by thomasanderson@ in https://codereview.chromium.org/2415933004 .
,
Jan 17 2017
,
Jan 17 2017
Unfortunately the libxkbcommon0 and libxkbcommon-dev packages aren't available in Wheezy. However, the packages are already in the jessie sysroot. tonikitoo@: What you can do is modify build/config/sysroot.gni to add a condition that checks for ozone wayland builds and uses the jessie sysroot instead. You will need to do something like in this CL: https://codereview.chromium.org/2361223002/diff/80001/build/config/sysroot.gni
,
Jan 17 2017
Thanks Tom. jessie sysroot is ARM64 (//src/build/linux/debian_jessie_arm64-sysroot/), not amd64. Is this the jessie sysroot you meant to be used?
,
Jan 18 2017
Ok, I now understood your comment in comment #3. I had a trailing jessie-arm64 sysroot deployed locally, which confused me. So from looking at build/config/sysroot.gni, chromeos/desktop builds require 'precise' sysroot downloaded. The idea here would be adding a new check where if chromeos/desktop/ozone/wayland builds, we use the jessie sysroot instead. Alternatively, https://codereview.chromium.org/2361223002/ would likely fix the problem at the bottom level. Will put a CL together anyways.
,
Jan 18 2017
Sorry, I un-cc'ed myself from this on accident, so was unable to reply. I added some comments on your CL.
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/121fdaf4f383c1618d86f14fb4a210e52769e467 commit 121fdaf4f383c1618d86f14fb4a210e52769e467 Author: thomasanderson <thomasanderson@google.com> Date: Wed Jan 18 21:01:23 2017 Add libxkbcommon packages to precise sysroot This CL: * Adds libxkbcommon0 and libxkbcommon-dev packages to the precise sysroot. * Modifies sysroot-creator.sh to support multiple repos. (eg. main, universe, multiverse). * Rolls sysroots BUG= 681562 R=dpranke@chromium.org CC=tonikitoo@chromium.org Review-Url: https://codereview.chromium.org/2645693002 Cr-Commit-Position: refs/heads/master@{#444475} [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.amd64 [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.arm [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.arm64 [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.i386 [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.jessie.mipsel [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.precise.amd64 [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/packagelist.trusty.arm [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroot-creator-precise.sh [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroot-creator.sh [modify] https://crrev.com/121fdaf4f383c1618d86f14fb4a210e52769e467/build/linux/sysroot_scripts/sysroots.json
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/c248030b38e02c9a6358a23a48363d63646f4230 commit c248030b38e02c9a6358a23a48363d63646f4230 Author: Tom Anderson <thomasanderson@google.com> Date: Mon Jan 23 22:41:12 2017 Add ozone config to chromium.fyi Ozone Linux BUG= 681562 R=dpranke@chromium.org Change-Id: I1b4f9c25e127558be73579df671d2b31bdd7dd66 Reviewed-on: https://chromium-review.googlesource.com/430993 Commit-Queue: Tom Anderson <thomasanderson@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/c248030b38e02c9a6358a23a48363d63646f4230/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/c248030b38e02c9a6358a23a48363d63646f4230/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Ozone_Linux.json [modify] https://crrev.com/c248030b38e02c9a6358a23a48363d63646f4230/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_ozone_compile_only_ng.json
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2d68eae813e2234e28798e81c423df7946fbe01 commit c2d68eae813e2234e28798e81c423df7946fbe01 Author: thomasanderson <thomasanderson@google.com> Date: Tue Jan 24 01:50:49 2017 Download Jessie sysroot on ozone builds BUG= 681562 R=dpranke@chromium.org CC=tonikitoo@igalia.com Review-Url: https://codereview.chromium.org/2645733006 Cr-Commit-Position: refs/heads/master@{#445588} [modify] https://crrev.com/c2d68eae813e2234e28798e81c423df7946fbe01/build/linux/sysroot_scripts/install-sysroot.py
,
Jan 24 2017
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58f836955cb7ca30cffc60a95bc337a5b6fa092c commit 58f836955cb7ca30cffc60a95bc337a5b6fa092c Author: tonikitoo <tonikitoo@igalia.com> Date: Wed Jan 25 19:24:06 2017 Build ozone/linux_os with jessie sysroot when use_ozone=true This is needed because Debian/wheezy (currently used) does not support libxkbcommon0/libxkbcommon-dev packages, needed for keyboard support on Ozone/Wayland. BUG= 681562 Review-Url: https://codereview.chromium.org/2645523003 Cr-Commit-Position: refs/heads/master@{#446081} [modify] https://crrev.com/58f836955cb7ca30cffc60a95bc337a5b6fa092c/build/config/sysroot.gni |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by toniki...@chromium.org
, Jan 16 2017