Issue metadata
Sign in to add a comment
|
libchrome.so is exporting unnecessary symbols |
||||||||||||||||||||
Issue descriptionRunning: "readelf -D -s libchrome.so" reveals a whole host of exported symbols, and running "readelf -S libchrome.so" shows: [ 3] .dynsym DYNSYM 0000018c 00018c 009f40 10 A 4 1 4 [ 4] .dynstr STRTAB 0000a0cc 00a0cc 02225c 00 A 0 0 1 The size of each being the 3rd hex column (about 180kb). Since we do manual JNI registration, we actually need to export only a single symbol: JNI_OnLoad. Cronet's already shipping with just that exported: https://cs.chromium.org/chromium/src/components/cronet/android/only_jni_exports.lst We should do the same for our other apps (make it the default on Android).
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/949e0700bc971d16fbb01ac68824a4557de8e31e commit 949e0700bc971d16fbb01ac68824a4557de8e31e Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Jan 16 14:44:49 2017 Update BUILD.gn to account for Android default linker script change BUG= 681557 Change-Id: I8fb4e50d241e3519b27d57a507d92cc3c15877ef Reviewed-on: https://chromium-review.googlesource.com/430877 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> [modify] https://crrev.com/949e0700bc971d16fbb01ac68824a4557de8e31e/src/tests/BUILD.gn [modify] https://crrev.com/949e0700bc971d16fbb01ac68824a4557de8e31e/BUILD.gn
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e45ac858cc5d25a1185bd4ecddc9632d41b390c commit 3e45ac858cc5d25a1185bd4ecddc9632d41b390c Author: jmadill <jmadill@chromium.org> Date: Wed Jan 25 19:11:03 2017 Roll ANGLE c1a5d16..d73f852 https://chromium.googlesource.com/angle/angle.git/+log/c1a5d16..d73f852 BUG= 681557 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2655053002 Cr-Commit-Position: refs/heads/master@{#446076} [modify] https://crrev.com/3e45ac858cc5d25a1185bd4ecddc9632d41b390c/DEPS |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by agrieve@chromium.org
, Jan 16 2017Status: Duplicate (was: Started)