ChromeActivityTestCaseBase.startMainActivityOnBlankPage regularly times out on Lollipop Phone tester |
|||
Issue descriptionThis is causing several tests to time out in chrome_public_test_apk on Lollipop Phone tester in a flaky manner. It seems we never get the notification that the tab finished loading about:blank, which is weird since from the error message it seems the tab did indeed finish to load the blank page. This may be related to errors in how we handle the loading state for a page on Android.
,
Jan 16 2017
I can see two main differences in the code compared to what's done at the content level: - Tab.java keeps track of a parameter m_isLoading, instead of querying directly the WebContents for its loading state. This leads to lines like: !tab.isLoading() && !tab.getWebContents().isLoadingToDifferentDocument(), which doesn't make sense from the content API POV. WebContents::IsLoadingToDifferentDocument does not make sense if WebContents::IsLoading is not true. In particuliar the implementation of WebContents::IsLoadingToDifferentDocument will always return false if WebContents::IsLoading is false. So either we have a discrepency between WebContents & Tab.java about wether they are loading or not (which is bad!) or the second part of the if clause is useless and should be removed. - The mechanism for waiting for a load to stop at the browser test level listens to the DidStopLoading notifications & not DidFinishLoad. This may explain disparities?
,
Mar 18 2017
hzl, can you look at this when you get a chance?
,
Aug 30
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted