Issue metadata
Sign in to add a comment
|
Text in blue button in popup infobar and sign in screen fades out. |
||||||||||||||||||||||
Issue descriptionApp Version: 57.0.2983.0 Canary iOS Version: 9.3.5 Device : iPad only Precondition : 1. Have few accounts saved. Steps to reproduce: Scenario 1 : 1. Launch chrome. 2. Open maps.google.com. 3. Notice that GAL infobar at the bottom. 4. Tap on Menu > Settings. Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpQVZUUmxhVjRhUDQ/view?usp=sharing Scenario 2 : 1. Launch chrome. 2. Tap on Menu > Settings > Sign in to chrome. Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpcGs4dTN6am81alE/view?usp=sharing Observed results: Text fades out displayed in blue button. Expected results: Text should not fade out. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): No in M55.0.2883.79 Bug reproducible on the current beta channel build (App Version, iOS Version): No in 56.0.2924.65 dev Good build : 57.0.2979. 0 canary Bad Build : 57.0.2980.0 canary
,
Jan 18 2017
Yes. I'll look into it.
,
Jan 19 2017
Reproes on Plus phones in landscape too. Reproes in MDC too: https://github.com/material-components/material-components-ios/issues/1160
,
Jan 19 2017
Found the cause and offending CL.
,
Jan 25 2017
https://codereview.chromium.org/2649043008 This might get fixed upstream, but this already fixes us. It's not a workaround, it's just that we explicitly say how we want the button to behave.
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76b2a485c54fb25c8a0fe271033715899c41a83c commit 76b2a485c54fb25c8a0fe271033715899c41a83c Author: lpromero <lpromero@chromium.org> Date: Wed Jan 25 16:24:42 2017 Prevent infobar buttons title color from changing when disabled BUG= 681538 R=jif@chromium.org Review-Url: https://codereview.chromium.org/2649043008 Cr-Commit-Position: refs/heads/master@{#446031} [modify] https://crrev.com/76b2a485c54fb25c8a0fe271033715899c41a83c/ios/chrome/browser/ui/infobars/infobar_view.mm
,
Jan 26 2017
Checked on Canary Version: 58.0.2993.0
,
Jan 26 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8800f7fad63d90317be975352e893fd7639a4dc5 commit 8800f7fad63d90317be975352e893fd7639a4dc5 Author: Louis Romero <lpromero@google.com> Date: Thu Jan 26 15:30:44 2017 Prevent infobar buttons title color from changing when disabled BUG= 681538 R=jif@chromium.org Review-Url: https://codereview.chromium.org/2649043008 Cr-Commit-Position: refs/heads/master@{#446031} (cherry picked from commit 76b2a485c54fb25c8a0fe271033715899c41a83c) Review-Url: https://codereview.chromium.org/2659613002 . Cr-Commit-Position: refs/branch-heads/2987@{#103} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/8800f7fad63d90317be975352e893fd7639a4dc5/ios/chrome/browser/ui/infobars/infobar_view.mm
,
Jan 31 2017
Verified in 58.0.2998.0 canary, iPad air 9.3.5 Looks good.
,
Feb 1 2017
Issue not fixed. Checked on chrome beta version 57.0.2987.18 on iPad Air with iOS 10.1.1. The color of the button still fades out.
,
Feb 13 2017
I don't repro on 57.0.2987.42 beta on iPad Air 10.1. Venu, can you check again? Do other configs work?
,
Feb 13 2017
verified the issue in the build 57.0.2987.50 dev and 57.0.2987.42 beta tested on iPad Air(10.1.1). Issue can be reproduced on Sign In and continue buttons. Attaching the video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpVk1IU1NGeTNILUE/view?usp=sharing
,
Feb 13 2017
Thanks! I repro with Sign in too. https://github.com/material-components/material-components-ios/commit/993edaa5512ce941e5e14e3737945aaa7468b4b5 is the fix, but we need for it to be released around Wednesday, then rolled in our tree. Then we can cherry-pick once it cleared a Canary.
,
Feb 14 2017
Thanks!
,
Feb 14 2017
The fix was released and rolled in our tree. I verified on Chrome Canary Version: 58.0.3012.0, the button is behaving correctly. Asking for merge to 57.
,
Feb 14 2017
,
Feb 14 2017
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57 Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2017
+cmasso for approval.
,
Feb 15 2017
https://drive.google.com/open?id=0B6GVWQnhaMClT1Vsb1ZTYk1qeEk Verified on iPad Air iOS 9.3.5 , iPad Pro iOS 10.2.1 on build 58.0.3013.0 Canary Text "Continue" button in Sign in to Chrome screen and "Restore" button in crash infobar looks good , they are not faded out.
,
Feb 15 2017
,
Feb 16 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 17 2017
Cherry-pick: $ git push origin 2987:refs/branch-heads/2987 Counting objects: 6, done. Delta compression using up to 24 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 587 bytes | 0 bytes/s, done. Total 6 (delta 5), reused 0 (delta 0) remote: Resolving deltas: 100% (5/5) remote: Processing changes: done To https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git 5f604cddce..4a0ab6ff58 2987 -> refs/branch-heads/2987
,
Feb 23 2017
Verified on iPad Air iOS 9.3.5 , iPad Pro iOS 10.2.1 on build 57.0.2987.75 dev Text "Continue" button in Sign in to Chrome screen and "Restore" button in crash infobar looks good , they are not faded out. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, Jan 18 2017Owner: lpromero@chromium.org
Status: Assigned (was: Untriaged)