Issue metadata
Sign in to add a comment
|
EDIT option is enabled on deleting all the histories. |
||||||||||||||||||||||
Issue descriptionApp Version: 57.0.2983.0 Canary iOS Version: 9.3.5, iOS 10 Device: iPhone,iPad Steps to reproduce: 1. Launch chrome. 2. Perform any search (say : news). 3. Tap on Menu > History. 4. Tap on Edit > Select the links. 5. Tap on Delete Observed results: Edit Option is Enabled. Expected results: Edit option should be disabled when no history entries are found. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): No in M55.0.2883.79 Bug reproducible on the current beta channel build (App Version, iOS Version): No in 56.0.2924.65 dev Good Build : 57.0.2929.0 canary Bad Build : 57.0.2930.0 Canary Link to Video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpTC1iWTFxQ2w1SE0/view?usp=sharing
,
Feb 6 2017
sczs@ any update here?
,
Feb 7 2017
,
Feb 7 2017
It was a simple fix and Jackie was kind enough to review it since Louis is OOO.
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf0aebdaabb28ca18c88568c7d92064d94a3046b commit bf0aebdaabb28ca18c88568c7d92064d94a3046b Author: sczs <sczs@chromium.org> Date: Tue Feb 07 03:08:44 2017 [ios] Update panel after history item deletion BUG= 681537 Review-Url: https://codereview.chromium.org/2680503004 Cr-Commit-Position: refs/heads/master@{#448532} [modify] https://crrev.com/bf0aebdaabb28ca18c88568c7d92064d94a3046b/ios/chrome/browser/ui/history/history_collection_view_controller.mm
,
Feb 7 2017
,
Feb 7 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 7 2017
,
Feb 7 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe12c7a861d6be62f4482f4a7201608804d68cf commit bbe12c7a861d6be62f4482f4a7201608804d68cf Author: Eugene But <eugenebut@google.com> Date: Tue Feb 07 18:02:53 2017 [ios] Update panel after history item deletion BUG= 681537 Review-Url: https://codereview.chromium.org/2680503004 Cr-Commit-Position: refs/heads/master@{#448532} (cherry picked from commit bf0aebdaabb28ca18c88568c7d92064d94a3046b) Review-Url: https://codereview.chromium.org/2678263006 . Cr-Commit-Position: refs/branch-heads/2987@{#362} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/bbe12c7a861d6be62f4482f4a7201608804d68cf/ios/chrome/browser/ui/history/history_collection_view_controller.mm
,
Feb 14 2017
Verified on chrome canary version 58.0.3012.0 on iPad4 10.2.1,iPhone 7plus 10.2.1,iPad mini 9.3.5 and iPhone5 9.3.5. Edit option is disabled when no history entries are found.
,
Feb 15 2017
Verified the issue in the latest beta 57.0.2987.53 tested on iPad mini 9.3.5,iPhone 6+ 9.3.5,iPhone7+ 10.2.1 and iPad air 10.1.1. Edit option is disabled when no history entries are found.
,
Mar 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, Jan 18 2017Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)